Date: Sat, 24 Mar 2018 16:03:11 +1100 (EST) From: Bruce Evans <brde@optusnet.com.au> To: rgrimes@freebsd.org Cc: Mark Johnston <markj@freebsd.org>, src-committers@freebsd.org, svn-src-user@freebsd.org Subject: Re: svn commit: r331461 - in user/markj/netdump/sys: kern netinet/netdump sys vm Message-ID: <20180324153246.V927@besplex.bde.org> In-Reply-To: <201803240246.w2O2kZnB033985@pdx.rh.CN85.dnsmgr.net> References: <201803240246.w2O2kZnB033985@pdx.rh.CN85.dnsmgr.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, 23 Mar 2018, Rodney W. Grimes wrote: >> Author: markj >> Date: Fri Mar 23 20:29:34 2018 >> New Revision: 331461 >> URL: https://svnweb.freebsd.org/changeset/base/331461 >> >> Log: >> Address some but not all review feedback from cem. > > Please be detailed in what is changing, as the above > only tells us where it came from in a vague way as > no review number is even cited. > > I know this is on a private branch, but when/if it > is merged this becomes part of the main line. Also, don't use spinmanagementspeak like "address" and "issue", or or programmerspeak like "kill". Bruce
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180324153246.V927>