From owner-p4-projects@FreeBSD.ORG  Mon Jun 14 04:27:30 2004
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id DEB1216A4D1; Mon, 14 Jun 2004 04:27:29 +0000 (GMT)
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id B90D116A4CE
	for <perforce@freebsd.org>; Mon, 14 Jun 2004 04:27:29 +0000 (GMT)
Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115])
	by mx1.FreeBSD.org (Postfix) with ESMTP id B2D0443D45
	for <perforce@freebsd.org>; Mon, 14 Jun 2004 04:27:29 +0000 (GMT)
	(envelope-from marcel@freebsd.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i5E4RTtU064655
	for <perforce@freebsd.org>; Mon, 14 Jun 2004 04:27:29 GMT
	(envelope-from marcel@freebsd.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i5E4RT38064652
	for perforce@freebsd.org; Mon, 14 Jun 2004 04:27:29 GMT
	(envelope-from marcel@freebsd.org)
Date: Mon, 14 Jun 2004 04:27:29 GMT
Message-Id: <200406140427.i5E4RT38064652@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	marcel@freebsd.org using -f
From: Marcel Moolenaar <marcel@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Subject: PERFORCE change 54899 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 14 Jun 2004 04:27:30 -0000

http://perforce.freebsd.org/chv.cgi?CH=54899

Change 54899 by marcel@marcel_nfs on 2004/06/14 04:26:32

	Skip registers of which we cannot get the values. This is
	needed on ia64, where the register frame has a variable
	size.
	
	While here, KNFify.

Affected files ...

.. //depot/projects/gdb/sys/ddb/db_print.c#3 edit

Differences ...

==== //depot/projects/gdb/sys/ddb/db_print.c#3 (text+ko) ====

@@ -46,27 +46,24 @@
 #include <ddb/db_sym.h>
 
 void
-db_show_regs(dummy1, dummy2, dummy3, dummy4)
-	db_expr_t	dummy1;
-	boolean_t	dummy2;
-	db_expr_t	dummy3;
-	char *		dummy4;
+db_show_regs(db_expr_t _1, boolean_t _2, db_expr_t _3, char *_4)
 {
-	register struct db_variable *regp;
-	db_expr_t	value, offset;
-	const char *	name;
+	struct db_variable *regp;
+	db_expr_t value, offset;
+	const char *name;
 
 	for (regp = db_regs; regp < db_eregs; regp++) {
-	    db_read_variable(regp, &value);
-	    db_printf("%-12s%#10lr", regp->name, (unsigned long)value);
-	    db_find_xtrn_sym_and_offset((db_addr_t)value, &name, &offset);
-	    if (name != NULL && offset <= (unsigned long)db_maxoff &&
-		offset != value) {
-		db_printf("\t%s", name);
-		if (offset != 0)
-		    db_printf("+%+#lr", (long)offset);
-	    }
-	    db_printf("\n");
+		if (!db_read_variable(regp, &value))
+			continue;
+		db_printf("%-12s%#10lr", regp->name, (unsigned long)value);
+		db_find_xtrn_sym_and_offset((db_addr_t)value, &name, &offset);
+		if (name != NULL && offset <= (unsigned long)db_maxoff &&
+		    offset != value) {
+			db_printf("\t%s", name);
+			if (offset != 0)
+				db_printf("+%+#lr", (long)offset);
+		}
+		db_printf("\n");
 	}
 	db_print_loc_and_inst(PC_REGS());
 }