From owner-svn-src-head@FreeBSD.ORG Mon Mar 26 18:22:26 2012 Return-Path: Delivered-To: svn-src-head@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id AA8381065687; Mon, 26 Mar 2012 18:22:26 +0000 (UTC) (envelope-from marius@alchemy.franken.de) Received: from alchemy.franken.de (alchemy.franken.de [194.94.249.214]) by mx1.freebsd.org (Postfix) with ESMTP id 3E77F8FC14; Mon, 26 Mar 2012 18:22:26 +0000 (UTC) Received: from alchemy.franken.de (localhost [127.0.0.1]) by alchemy.franken.de (8.14.4/8.14.4/ALCHEMY.FRANKEN.DE) with ESMTP id q2QIMOA2089071; Mon, 26 Mar 2012 20:22:24 +0200 (CEST) (envelope-from marius@alchemy.franken.de) Received: (from marius@localhost) by alchemy.franken.de (8.14.4/8.14.4/Submit) id q2QIMOQw089070; Mon, 26 Mar 2012 20:22:24 +0200 (CEST) (envelope-from marius) Date: Mon, 26 Mar 2012 20:22:24 +0200 From: Marius Strobl To: Alexander Kabaev Message-ID: <20120326182224.GU37560@alchemy.franken.de> References: <201203212055.q2LKtMYR093218@svn.freebsd.org> <20120325162528.7f73300c@kan.dyndns.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120325162528.7f73300c@kan.dyndns.org> User-Agent: Mutt/1.4.2.3i Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r233288 - in head/sys: boot/common libkern sys X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Mar 2012 18:22:26 -0000 On Sun, Mar 25, 2012 at 04:25:28PM -0400, Alexander Kabaev wrote: > On Wed, 21 Mar 2012 20:55:22 +0000 (UTC) > Marius Strobl wrote: > > > > Modified: head/sys/sys/libkern.h > > ============================================================================== > > --- head/sys/sys/libkern.h Wed Mar 21 20:53:47 2012 > > (r233287) +++ head/sys/sys/libkern.h Wed Mar 21 20:55:21 > > 2012 (r233288) @@ -121,7 +121,7 @@ size_t strspn(const > > char *, const char char *strstr(const char *, const char *); > > int strvalid(const char *, size_t); > > > > -extern uint32_t crc32_tab[]; > > +extern const uint32_t const crc32_tab[]; > > > > static __inline uint32_t > > crc32_raw(const void *buf, size_t size, uint32_t crc) > > Hi, > > > g++ produces "error: duplicate 'const'" on this changed line. Leaving > the question as to why this file is ever being compiled by C++ on the > conscience of of VirtualBox authors, I would suggest partially backing > out this commit and getting easier on 'const' for C++'s sake. > Done in r233517. Marius