From nobody Sun Jul 12 15:35:36 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gyqQc4GFsz6lWZf for ; Sun, 12 Jul 2026 15:35:36 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gyqQc3QDdz43Wp for ; Sun, 12 Jul 2026 15:35:36 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1783870536; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=09g4WJ4wLfWHMv7Mwmgy9Ll4ITGr10kqNWZvRBs8c/o=; b=jDt+iWsyHDHR7bk6S9vd58tmUD9x6UiGHK0AYNuy5HrBDNSvnb2cJHQhlXfTj/dg+7VJ0E U9lWgqtMtklOQ22dXsW7AASk6vsAlSewyfCvYDTwxrEYFZaVRG5XA0JVso980IJxS3YA5u RgcXWLMrbelyMXdXpQBT0nykmKgeofVJL8Rz70vVj+F3Q4OAZ7Uo16Nwx6ZZajxxcYm6nw FQ9g0jWRpgmuJUw19Hi0/8Y3evDJUpVKNoUk8GCGSaGjtDOi1uIAH8R4Mll+ASmx9E89y4 VNP0hxVuqE5O/0/IRtBlGolkkJl7HO5o0lAtxjem+H+L8wy/xc/mUZwUlcMqqA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1783870536; a=rsa-sha256; cv=none; b=xp9VaWrOaDMoNdXwEXVUtkuC+1DJJpC6yR1GrUjsYteomymK3t3h162idQxEDczQdkIFI5 /xgSXykmDyGyI3gv9kIpJTIpBeHNkagpGBqCs+B3J/lafCPcftXYRT4Mu9hvYjlnYtMBed ojcjTDrJgLgQyrZ9/vRbLlLQ7MWr8nOaGTUTtPtV+Yoy9rlyXJChN/WQ24lOoeJMJg0/Gd zw1EGyRjJzQQ96T3+OO1pzRyWaB5IneaCIKO8OaB8GLZifIzeL6ZZRCmsNiF8GtIY4hNYp zWwig58m2sqNo9LLi7XDngbuGURNwedHhp2+ASC55Iz5YeNWuNnOP2BKWfyq+w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1783870536; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=09g4WJ4wLfWHMv7Mwmgy9Ll4ITGr10kqNWZvRBs8c/o=; b=wKAj9o/6wFvJkHOoAh6l9qrKEXnH3+V8At49oS4YU6friEUnsyhAc6o+VH+WpfepQCzXzB NdFwWxFPgxk9Cm8R8YV2ZgGX45VxwJJ6JTuhf8jy5mz/0LTcdAo3fGONYWnFLkPsdGFrTK TDD4pcHf3afBRiEfIZO+UmKcRj6PgofNvUyD6RUpNJXjmvt2VN/Q5ZbBtbuLka69ycZILj a4QQ3vhvTy5Siw/pa6/IIHKPlm3oxwdfJVxlrutTr+dhXvd6gTrzhhHfwfukVHArj9jHTU Kcm2hk6gzYWS7a4X1lmd/If5606IRpgQ7tnBaE1QJvDwYgXehTnZIob40LSFkQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4gyqQc2ChRz2vP for ; Sun, 12 Jul 2026 15:35:36 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3ff16 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Sun, 12 Jul 2026 15:35:36 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Adrian Chadd Subject: git: 7aa34e12c9e1 - main - rge: fix multicast add/removal by using if_getdrvflags() List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: adrian X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 7aa34e12c9e198bf8b7e74370ff702def5ec2649 Auto-Submitted: auto-generated Date: Sun, 12 Jul 2026 15:35:36 +0000 Message-Id: <6a53b448.3ff16.15f8f9c3@gitrepo.freebsd.org> The branch main has been updated by adrian: URL: https://cgit.FreeBSD.org/src/commit/?id=7aa34e12c9e198bf8b7e74370ff702def5ec2649 commit 7aa34e12c9e198bf8b7e74370ff702def5ec2649 Author: Adrian Chadd AuthorDate: 2026-07-12 15:26:46 +0000 Commit: Adrian Chadd CommitDate: 2026-07-12 15:26:46 +0000 rge: fix multicast add/removal by using if_getdrvflags() Using if_getflags() to check IFF_DRV_RUNNING is wrong; if_getdrvflags() is required. This issue resulted in the multicast filter not being updated. This was an oversight by me in my initial port. Thanks to danilo@ for reporting it and Oleg for the fix. PR: kern/295176 --- sys/dev/rge/if_rge.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/dev/rge/if_rge.c b/sys/dev/rge/if_rge.c index 61dcac390765..7c11da5c3f53 100644 --- a/sys/dev/rge/if_rge.c +++ b/sys/dev/rge/if_rge.c @@ -951,7 +951,7 @@ rge_ioctl(struct ifnet *ifp, u_long cmd, caddr_t data) case SIOCADDMULTI: case SIOCDELMULTI: RGE_LOCK(sc); - if ((if_getflags(ifp) & IFF_DRV_RUNNING) != 0) + if ((if_getdrvflags(ifp) & IFF_DRV_RUNNING) != 0) rge_iff_locked(sc); RGE_UNLOCK(sc); break;