From owner-cvs-all  Mon Apr  8  0: 4: 6 2002
Delivered-To: cvs-all@freebsd.org
Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16])
	by hub.freebsd.org (Postfix) with ESMTP
	id C5FAC37B41A; Mon,  8 Apr 2002 00:04:01 -0700 (PDT)
Received: from bde.zeta.org.au (bde.zeta.org.au [203.2.228.102])
	by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id RAA15400;
	Mon, 8 Apr 2002 17:03:59 +1000
Date: Mon, 8 Apr 2002 17:04:01 +1000 (EST)
From: Bruce Evans <bde@zeta.org.au>
X-X-Sender: bde@gamplex.bde.org
To: Ruslan Ermilov <ru@FreeBSD.org>
Cc: "David E. O'Brien" <obrien@FreeBSD.org>,
	Bruce Evans <bde@FreeBSD.org>, <cvs-all@FreeBSD.org>
Subject: Re: cvs commit: src/gnu/usr.bin/cc/cc1 Makefile src/gnu/usr.bin/cc/cc1obj
 Makefile src/gnu/usr.bin/cc/cc1plus Makefile
In-Reply-To: <20020407162550.GE67968@sunbay.com>
Message-ID: <20020408165120.S5876-100000@gamplex.bde.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

On Sun, 7 Apr 2002, Ruslan Ermilov wrote:

> On Wed, Apr 03, 2002 at 04:50:14PM -0800, David E. O'Brien wrote:
> > obrien      2002/04/03 16:50:14 PST
> >
> >   Modified files:
> >     gnu/usr.bin/cc/cc1   Makefile
> >     gnu/usr.bin/cc/cc1obj Makefile
> >     gnu/usr.bin/cc/cc1plus Makefile
> >   Log:
> >   Set NOSHARED conditionally.
> >
> Why?  Conditionally setting NOSHARED only makes sense in Makefile.inc
> where it may be overridden by individual makefiles beneath it.
> (Seeing if Bruce agrees.)

I've already objected to this commit for almost the opposite reason.

It makes sense to set some `make' variables conditionally, and NOSHARED
is one of these.  Users can set it before the Makefile is invoked, and
NOSHARED?= is used in most places to avoid clobbering such earlier
settings.  However, in the special case of the large first passes of
cc, we (people who set NOSHARED here previously) think that clobbering
earlier settings is right, because the space savings are small and the
time savings are large for using NOSHARED unconditionally.  This is
not very well documented.  The only hint of it in the logs is
"appropriately" in rev.1.12 of cc1/Makefile, etc.  Setting NOSHARED
conditionally was considered to be appropriate [almost?] everywhere
except in the above Makefiles.

Bruce


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message