From owner-cvs-src@FreeBSD.ORG Tue Mar 25 18:59:56 2008 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 521261065673; Tue, 25 Mar 2008 18:59:56 +0000 (UTC) (envelope-from rermilov@team.vega.ru) Received: from mail.vega.ru (infra.dev.vega.ru [90.156.167.14]) by mx1.freebsd.org (Postfix) with ESMTP id 0F52A8FC24; Tue, 25 Mar 2008 18:59:56 +0000 (UTC) (envelope-from rermilov@team.vega.ru) Received: from [87.242.97.68] (port=61905 helo=edoofus.dev.vega.ru) by mail.vega.ru with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.68 (FreeBSD)) (envelope-from ) id 1JeE2Y-0003jk-HV; Tue, 25 Mar 2008 18:38:30 +0000 Received: from edoofus.dev.vega.ru (localhost [127.0.0.1]) by edoofus.dev.vega.ru (8.14.2/8.14.2) with ESMTP id m2PIboCd051916; Tue, 25 Mar 2008 21:37:50 +0300 (MSK) (envelope-from rermilov@team.vega.ru) Received: (from ru@localhost) by edoofus.dev.vega.ru (8.14.2/8.14.2/Submit) id m2PIboFk051915; Tue, 25 Mar 2008 21:37:50 +0300 (MSK) (envelope-from rermilov@team.vega.ru) X-Authentication-Warning: edoofus.dev.vega.ru: ru set sender to rermilov@team.vega.ru using -f Date: Tue, 25 Mar 2008 21:37:50 +0300 From: Ruslan Ermilov To: Alfred Perlstein Message-ID: <20080325183750.GA51894@team.vega.ru> References: <200803250939.m2P9d3RC028128@repoman.freebsd.org> <20080325180152.GB67856@elvis.mu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080325180152.GB67856@elvis.mu.org> User-Agent: Mutt/1.5.17 (2007-11-01) Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/en midway.c src/sys/dev/fatm if_fatm.c src/sys/dev/firewire if_fwe.c if_fwip.c src/sys/dev/iscsi/initiator isc_soc.c src/sys/kern subr_mchain.c uipc_mbuf.c uipc_socket.c uipc_syscalls.c src/sys/net bpf.c ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Mar 2008 18:59:56 -0000 On Tue, Mar 25, 2008 at 11:01:52AM -0700, Alfred Perlstein wrote: > I don't think this was thought out enough, there are times when you > would want to limit the total memory allocated to mbufs and avoid > deadlocks in low memory situations. > > Even the old allocator could have been trivially modified to block > forever upon exhaustion of the mbuf arena. > > The reason why the old allocator was not "fixed" to block forever > was to allow for recovery from low memory deadlocks. > > A lot of work went into making the system safe in the face of these > deadlocks and removing it "to clean up" due to a deficiency with > the current allocator and without understanding why it was there > in the first place is a mistake. > > This whole thing needs to be backed out. > Are you (or anyone else you know) planning to work on adding real support for M_TRYWAIT? Cheers, -- Ruslan Ermilov ru@FreeBSD.org FreeBSD committer