Date: Thu, 19 May 2016 10:23:13 -0600 From: Scott Long <scott4long@yahoo.com> To: Alexander Motin <mav@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r300201 - head/sys/sys Message-ID: <D576167F-BA5E-43F5-A5A8-798B0C3B5A68@yahoo.com> In-Reply-To: <201605191119.u4JBJb9f027906@repo.freebsd.org> References: <201605191119.u4JBJb9f027906@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Thanks! Scott > On May 19, 2016, at 5:19 AM, Alexander Motin <mav@FreeBSD.org> wrote: >=20 > Author: mav > Date: Thu May 19 11:19:37 2016 > New Revision: 300201 > URL: https://svnweb.freebsd.org/changeset/base/300201 >=20 > Log: > Add ta_flags initialization in old macros missed in 300113. >=20 > Depending on uninitialized memory content it could cause loss of = wakeup() > call in taskqueue_run_locked(). >=20 > Modified: > head/sys/sys/taskqueue.h >=20 > Modified: head/sys/sys/taskqueue.h > = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D > --- head/sys/sys/taskqueue.h Thu May 19 11:02:39 2016 = (r300200) > +++ head/sys/sys/taskqueue.h Thu May 19 11:19:37 2016 = (r300201) > @@ -97,6 +97,7 @@ void taskqueue_set_callback(struct taskq >=20 > #define TASK_INITIALIZER(priority, func, context) \ > { .ta_pending =3D 0, \ > + .ta_flags =3D 0, \ > .ta_priority =3D (priority), \ > .ta_func =3D (func), \ > .ta_context =3D (context) } > @@ -112,6 +113,7 @@ void taskqueue_thread_enqueue(void *cont > */ > #define TASK_INIT(task, priority, func, context) do { \ > (task)->ta_pending =3D 0; \ > + (task)->ta_flags =3D 0; \ > (task)->ta_priority =3D (priority); \ > (task)->ta_func =3D (func); \ > (task)->ta_context =3D (context); \ >=20
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?D576167F-BA5E-43F5-A5A8-798B0C3B5A68>