From owner-freebsd-hackers@FreeBSD.ORG Thu Mar 6 10:19:06 2008 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 764EC1065673 for ; Thu, 6 Mar 2008 10:19:06 +0000 (UTC) (envelope-from walraven@terantula.com) Received: from mx.terantula.com (mx.terantula.com [212.61.39.65]) by mx1.freebsd.org (Postfix) with ESMTP id 37DD48FC18 for ; Thu, 6 Mar 2008 10:19:05 +0000 (UTC) (envelope-from walraven@terantula.com) Received: from localhost (localhost [127.0.0.1]) by mx.terantula.com (Postfix) with ESMTP id E47E9140E4 for ; Thu, 6 Mar 2008 10:52:54 +0100 (CET) X-Virus-Scanned: amavisd-new at terantula.com Received: from mx.terantula.com ([127.0.0.1]) by localhost (cotton.terantula.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 3PoNH7yP7koV for ; Thu, 6 Mar 2008 10:52:52 +0100 (CET) Received: by mx.terantula.com (Postfix, from userid 1002) id BAFED140E1; Thu, 6 Mar 2008 10:52:52 +0100 (CET) Date: Thu, 6 Mar 2008 10:52:52 +0100 From: Marco Walraven To: freebsd-hackers@freebsd.org Message-ID: <20080306095252.GP19542@cotton.terantula.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.4.2.3i Organisation: Terantula Subject: make index during make release generates wrong INDEX file X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Mar 2008 10:19:06 -0000 Hi, I ran into a wrongly named INDEX file today after I did a 'make release' of RELENG_7 on a RELENG_6 system which includes the Ports Collection. The index file is named INDEX-6 instead of INDEX-7. A quick look in Mk/bsd.port.subdir.mk shows me that it will read the version from the param.h file found in either /usr/include/sys/ or /usr/src/sys/sys/ and will name the INDEX- file according to what it found. The first location holds the file from of my running system RELENG_6 (outcome of the make buildworld on which make release depends); the second location holds the RELENG_7 file, checked out during 'make release'. Shouldn't it check the param.h file that is in my chrooted environment and use the version it finds in there while doing a make release instead of the param.h from the make buildworld outcome ? Ofcourse this works fine if you are running, let's say RELENG_6 and you want to make a release for that branch as well cause then they are equal(ly). Quickfix would be to specify OSVERSION in the make.conf; however if there is already a chrooted env why should you have to specify OSVERSION since it can get the exact version from the param.h file in the chrooted env ? Thanks, Marco -- Terantula - Industrial Strength Open Source phone:+31 64 3232 400 / www: http://www.terantula.com / pgpkey: E7EE7A46 pgp fingerprint: F2EE 122D 964C DE68 7380 6F95 3710 7719 E7EE 7A46