Date: Sun, 11 May 2014 18:32:39 GMT From: Mazhe <mazhe@alkumuna.eu> To: freebsd-gnats-submit@FreeBSD.org Subject: ports/189680: [patch] support for staging in graphics/epdfview Message-ID: <201405111832.s4BIWdLH007547@cgiserv.freebsd.org> Resent-Message-ID: <201405111840.s4BIe0cK056145@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 189680
>Category: ports
>Synopsis: [patch] support for staging in graphics/epdfview
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: update
>Submitter-Id: current-users
>Arrival-Date: Sun May 11 18:40:00 UTC 2014
>Closed-Date:
>Last-Modified:
>Originator: Mazhe
>Release: 10.0-RELEASE-p3
>Organization:
-
>Environment:
FreeBSD freedom.alkumuna.eu 10.0-RELEASE-p1 FreeBSD 10.0-RELEASE-p1 #0: Tue Apr 8 06:45:06 UTC 2014 root@amd64-builder.daemonology.net:/usr/obj/usr/src/sys/GENERIC amd64
>Description:
graphics/epdfview is still lacking staging support while the deadline is approaching.
>How-To-Repeat:
-
>Fix:
See attached patch. It also fix cups name in lib_depends as suggested by portlint.
Patch attached with submission follows:
Index: Makefile
===================================================================
--- Makefile (revision 353722)
+++ Makefile (working copy)
@@ -26,14 +26,11 @@
OPTIONS_DEFINE= CUPS NLS
-MAN1= epdfview.1
-
-NO_STAGE= yes
.include <bsd.port.options.mk>
.if ${PORT_OPTIONS:MCUPS}
CONFIGURE_ARGS+=--with-cups
-LIB_DEPENDS+= cups.2:${PORTSDIR}/print/cups-client
+LIB_DEPENDS+= libcups.so:${PORTSDIR}/print/cups-client
.else
CONFIGURE_ARGS+=--without-cups
.endif
@@ -54,7 +51,7 @@
post-install:
${REINPLACE_CMD} -e 's,Icon.*,Icon=${DATADIR}/pixmaps/icon_epdfview-48.png,' ${WRKSRC}/data/${PORTNAME}.desktop
- ${INSTALL_DATA} ${WRKSRC}/data/${PORTNAME}.desktop ${PREFIX}/share/applications/
+ ${INSTALL_DATA} ${WRKSRC}/data/${PORTNAME}.desktop ${STAGEDIR}${LOCALBASE}/share/applications/
@-update-desktop-database
.include <bsd.port.mk>
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201405111832.s4BIWdLH007547>