From owner-cvs-src@FreeBSD.ORG Thu Jul 10 02:25:17 2008 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 65AC3106567A; Thu, 10 Jul 2008 02:25:17 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from server.baldwin.cx (bigknife-pt.tunnel.tserv9.chi1.ipv6.he.net [IPv6:2001:470:1f10:75::2]) by mx1.freebsd.org (Postfix) with ESMTP id ED4AC8FC12; Thu, 10 Jul 2008 02:25:16 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from localhost.corp.yahoo.com (john@localhost [IPv6:::1]) (authenticated bits=0) by server.baldwin.cx (8.14.2/8.14.2) with ESMTP id m6A2OvAv028341; Wed, 9 Jul 2008 22:25:10 -0400 (EDT) (envelope-from jhb@FreeBSD.org) From: John Baldwin To: Rui Paulo Date: Wed, 9 Jul 2008 21:39:12 -0400 User-Agent: KMail/1.9.7 References: <200807052319.m65NJgp8097891@repoman.freebsd.org> In-Reply-To: <200807052319.m65NJgp8097891@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200807092139.12985.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [IPv6:::1]); Wed, 09 Jul 2008 22:25:11 -0400 (EDT) X-Virus-Scanned: ClamAV 0.93.1/7680/Wed Jul 9 19:31:16 2008 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-2.5 required=4.2 tests=AWL,BAYES_00,NO_RELAYS autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/k8temp k8temp.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Jul 2008 02:25:17 -0000 On Saturday 05 July 2008 07:19:37 pm Rui Paulo wrote: > rpaulo 2008-07-05 23:19:37 UTC > > FreeBSD src repository > > Modified files: > sys/dev/k8temp k8temp.c > Log: > SVN rev 180312 on 2008-07-05 23:19:37Z by rpaulo > > Use config_intrhook API to create the dev.cpu.N.temperature sysctl node. > Our hook creates the sysctl node before root is mounted, but after cpu > is probed. It seems that k8temp can be loaded before the cpu module and, > in those cases, dev.cpu.0.temperature was not created. Err, why not rework this so that you have a k8tempctl0 device that attaches to the PCI part (or just use it directly like ichss0 does) and then have a per-CPU k8temp0 device? This would be a cleaner solution w/o needing an intrhook (and would also work if someone disables ACPI). -- John Baldwin