From owner-svn-ports-all@freebsd.org Fri Mar 2 07:23:22 2018 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 73024F2ADE0; Fri, 2 Mar 2018 07:23:22 +0000 (UTC) (envelope-from koobs.freebsd@gmail.com) Received: from mail-pl0-x22f.google.com (mail-pl0-x22f.google.com [IPv6:2607:f8b0:400e:c01::22f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id EA571718D1; Fri, 2 Mar 2018 07:23:21 +0000 (UTC) (envelope-from koobs.freebsd@gmail.com) Received: by mail-pl0-x22f.google.com with SMTP id m22-v6so1701477pls.5; Thu, 01 Mar 2018 23:23:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:reply-to:subject:to:references:from:cc:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=fbGaYQEWEsdjkg9e0v45faSH+wj5KmiFrKPoNDeh+Ck=; b=GToF2ML5fy7ogfpytQxoV3q+iVj+zfe9iSjXgs9cRvnq/ycs+D8jsLUvroblaLtH50 aoeqnNqvwvZJuxpJtePMHAVqZGNAWgveTrVE48iK8hBp6NZy7yK8M80e3itlXAZldhZ8 NbSD1PPc+SwMepk0q+60igFCs3bnezH/heghzo0uzLbGm4FZr7BEnixiGs8pTJKd+JuP dvgIOhPtuCvTcu4xfxMr8ha32/2BcQhzu+ceee/bKbTXt94/sA0/Pns7K7fHGZBZcIuS 6IZGaAa7ZwXFpdP495uept5lm8hieW6S0CJ+TPIHYhc0LptM8Zd/k8j/qdqu5Vom0jgB 2pnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:reply-to:subject:to:references:from:cc :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=fbGaYQEWEsdjkg9e0v45faSH+wj5KmiFrKPoNDeh+Ck=; b=c1xrIjEf0bzd9+L7/lmjeRxGBB480kTmfoZpKuSIS2Znh8v8eTwBQdj8txQYiVnIC+ npOL+JApmtANNUXM4gG8BOdw44NheR07ku0BSmDutcYifqKf+7yzAcaEDLRnUt7njEeX t5lLYRPPtw/2vwevH/VwNIUgaHn8zaQaB1hyuZKIZuSqdt8z7gTbYmJHTgWN7x/azBaD vaGFwyUS6TbE5PZOrkKo880uOQvWCPq9MKrmL6Z7aYP2PFFOnt3Gns63kcITxBVOVzBF WRwPMSrdz+YR0/uV/ZLfkCNqvkqXkLINEPhyjLaeJjZW1jMKPN9flDQyLY1yu6JfKVa+ ImZQ== X-Gm-Message-State: APf1xPDAc8kDU1jaKLBr8ABiQ22wE5K1/WdVBRYWVyU0nppK8OtkHOxg imZ3d+6hE0OYGFKUXnR7CM+LMDvh X-Google-Smtp-Source: AG47ELv1nvTfwiN6k/RHyY61ax0FOSwRydvVr770TaRHlsoazln1P8MRiLKAyQqOR29Y2VrtXkNRew== X-Received: by 2002:a17:902:599b:: with SMTP id p27-v6mr4281087pli.289.1519975400676; Thu, 01 Mar 2018 23:23:20 -0800 (PST) Received: from [192.168.1.100] (152.94.214.218.sta.wbroadband.net.au. [218.214.94.152]) by smtp.gmail.com with ESMTPSA id p128sm8921403pga.45.2018.03.01.23.23.18 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 01 Mar 2018 23:23:20 -0800 (PST) Sender: Kubilay Kocak Reply-To: koobs@FreeBSD.org Subject: Re: svn commit: r463374 - head/security/nyx To: Yuri Victorovich , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org, python References: <201803020651.w226ptn3091275@repo.freebsd.org> From: Kubilay Kocak Cc: "Tobias C. Berner" Message-ID: <6f698e1f-a5d5-2cd7-b2b7-c288a3c65bb6@FreeBSD.org> Date: Fri, 2 Mar 2018 18:23:16 +1100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:54.0) Gecko/20100101 Thunderbird/54.0a2 MIME-Version: 1.0 In-Reply-To: <201803020651.w226ptn3091275@repo.freebsd.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-AU Content-Transfer-Encoding: 7bit X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Mar 2018 07:23:22 -0000 On 3/2/18 5:51 PM, Yuri Victorovich wrote: > Author: yuri > Date: Fri Mar 2 06:51:55 2018 > New Revision: 463374 > URL: https://svnweb.freebsd.org/changeset/ports/463374 > > Log: > security/nyx: Add USE_PYTHON=noflavors; Add LICENSE_FILE > > nyx is an app, therefore noflavors. This reason doesn't sound correct. Could you explain this further? Context: FLAVORS are for package building infrastructure to produce multiple variations of the same underlying port, within the same repository/run, in Pythons case, for multiple python versions (pyXY-foo). Whether something is an 'app' or not (by some definition, though i'm assuming it means 'end user program not library'), does not factor into whether or not it has or needs flavors, just whether it supports multiple versions. Note: Whether or not a port has flavor's is orthogonal (in pythons case) to whether or not said packages are, or desired to be by the user, concurrently installable or not. > > Approved by: tcberner (mentor, implicit) > Approved by: portmgr (port compliance, infrastructure) > > Modified: > head/security/nyx/Makefile > > Modified: head/security/nyx/Makefile > ============================================================================== > --- head/security/nyx/Makefile Fri Mar 2 06:31:47 2018 (r463373) > +++ head/security/nyx/Makefile Fri Mar 2 06:51:55 2018 (r463374) > @@ -12,12 +12,13 @@ MAINTAINER= cs@FreeBSD.org > COMMENT= Command-line monitor for Tor > > LICENSE= GPLv3 > +LICENSE_FILE= ${WRKSRC}/LICENSE > > -RUN_DEPENDS= ${PYTHON_PKGNAMEPREFIX}stem>=1.6.0:security/py-stem@${FLAVOR} \ > - ${PYTHON_PKGNAMEPREFIX}sqlite3>0:databases/py-sqlite3@${FLAVOR} > +RUN_DEPENDS= ${PYTHON_PKGNAMEPREFIX}stem>=1.6.0:security/py-stem@${PY_FLAVOR} \ > + ${PYTHON_PKGNAMEPREFIX}sqlite3>0:databases/py-sqlite3@${PY_FLAVOR} > > USES= python > -USE_PYTHON= distutils autoplist > +USE_PYTHON= distutils autoplist noflavors > NO_ARCH= yes > > PLIST_FILES= man/man1/nyx.1.gz >