Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 04 Nov 2022 21:33:32 +0000
From:      Lorenzo Salvadore <developer@lorenzosalvadore.it>
To:        Yasuhiro Kimura <yasu@FreeBSD.org>
Cc:        salvadore@FreeBSD.org, ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org, Gerald Pfeifer <gerald@FreeBSD.org>
Subject:   Re: git: dc67e7d3009d - main - lang/gcc11: Fix conflict on libgccjit.h and libgccjig++.h
Message-ID:  <2bh1ddDgS0AORs5m50qQWi-XpzDAx98GV8uVs6mx0vz5iTCygo2eo8SY-2nTmhvvtcg-n1aW4ZCTskAHSKkPnOiI6kDf_3FCFckibZzgHdM=@lorenzosalvadore.it>
In-Reply-To: <j7FRFrpUI1Un-O3IZMZtU9zPd_vwmrS6VZ9c3rtWTvz93OqR79AuY7c9p8D_wUo0PXMI_dHMCHMQIIp12BfWB4eahDvo3L27S77RJWC6KGY=@lorenzosalvadore.it>
References:  <202211031229.2A3CToIj005790@gitrepo.freebsd.org> <20221104.110312.1490285664477590823.yasu@FreeBSD.org> <j7FRFrpUI1Un-O3IZMZtU9zPd_vwmrS6VZ9c3rtWTvz93OqR79AuY7c9p8D_wUo0PXMI_dHMCHMQIIp12BfWB4eahDvo3L27S77RJWC6KGY=@lorenzosalvadore.it>

next in thread | previous in thread | raw e-mail | index | archive | help
------- Original Message -------
On Friday, November 4th, 2022 at 4:40 PM, Lorenzo Salvadore <developer@lore=
nzosalvadore.it> wrote:


>=20
>=20
> ------- Original Message -------
> On Friday, November 4th, 2022 at 3:03 AM, Yasuhiro Kimura yasu@FreeBSD.or=
g wrote:
>=20
>=20
>=20
> > From: Lorenzo Salvadore salvadore@FreeBSD.org
> >=20
> > Subject: git: dc67e7d3009d - main - lang/gcc11: Fix conflict on libgccj=
it.h and libgccjig++.h
> > Date: Thu, 3 Nov 2022 12:29:50 GMT
> >=20
> > > The branch main has been updated by salvadore:
> > >=20
> > > URL: https://cgit.FreeBSD.org/ports/commit/?id=3Ddc67e7d3009de2b78d96=
136c8ad09cf186e553df
> > >=20
> > > commit dc67e7d3009de2b78d96136c8ad09cf186e553df
> > > Author: Lorenzo Salvadore salvadore@FreeBSD.org
> > > AuthorDate: 2022-11-02 22:24:57 +0000
> > > Commit: Lorenzo Salvadore salvadore@FreeBSD.org
> > > CommitDate: 2022-11-03 12:29:06 +0000
> > >=20
> > > lang/gcc11: Fix conflict on libgccjit.h and libgccjig++.h
> > >=20
> > > GCC 11, GCC 12 and GCC 13 install libgccjit.h and libgccjit++.h in th=
e
> > > same directory.
> > >=20
> > > Fix conflict for GCC 11, which is GCC_DEFAULT, by installing those fi=
les
> > > in a directory specific to GCC 11.
> > >=20
> > > PR: 257060
> > > Reported by: Ting-Wei Lan lantw44@gmail.com
> > > Reviewed by: gerald, dim
> > > Differential Revision: https://reviews.freebsd.org/D37242
> > > See also: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D101491
> >=20
> > After this commit build of editors/emacs-devel fails as configure
> > script fails to detect libgccjit.h as following.
> >=20
> > ----------------------------------------------------------------------
> > checking for dlopen... (cached) yes
> > checking for dladdr... yes
> > checking for dlfunc... yes
> > checking for gcc_jit_context_acquire in -lgccjit... yes
> > checking for libgccjit.h... no
> > configure: error: ELisp native compiler was requested, but libgccjit he=
ader files were
> > not found.
> > Please try installing libgccjit-dev or a similar package.
> > If you are sure you want Emacs be compiled without ELisp native compile=
r,
> > pass the --without-native-compilation option to configure.
> > =3D=3D=3D> Script "configure" failed unexpectedly.
> >=20
> > Please report the problem to emacs@FreeBSD.org [maintainer] and attach =
the
> > "/wrkdirs/usr/ports/editors/emacs-devel/work-nox/emacs-a691e811/config.=
log"
> > including the output of the failure of your make command. Also, it migh=
t be
> > a good idea to provide an overview of all packages installed on your sy=
stem
> > (e.g. a /usr/local/sbin/pkg-static info -g -Ea).
> > *** Error code 1
> >=20
> > Stop.
> > make: stopped in /usr/ports/editors/emacs-devel
> > ----------------------------------------------------------------------
> >=20
> > According to the output of `pkg info -l gcc11-11.3.0_3` on
> > 13.1-RELEASE amd64, both libgccjit.h and libgccjit++.h are installed
> > in /usr/local/lib/gcc11/gcc/x86_64-portbld-freebsd13.1/include. But
> > should they be installed in
> > /usr/local/lib/gcc11/gcc/x86_64-portbld-freebsd13.1/11.3.0/include?
>=20
>=20
> I have fixed the patch, but emacs still fails to find the header, so
> instead of committing the fix I have put it in Phabricator for review
> and improvements:
>=20
> https://reviews.freebsd.org/D37266
>=20
> As I suggest in the review, it might be better to change the emacs port
> so that they search the header in the right directory, but if this is
> not possible we can search for a better solution (or revert the
> commit that broke emacs, if finding such a solution takes too much
> time).
>=20
> Cheers,
>=20
> Lorenzo Salvadore

Fixing the commit does not seem to be a straight forward task, so I have
reverted it for now:

https://cgit.freebsd.org/ports/commit/?id=3D9f0cd13014d0962aedfa016c86a5af0=
7ca3ba814

Cheers,

Lorenzo Salvadore



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?2bh1ddDgS0AORs5m50qQWi-XpzDAx98GV8uVs6mx0vz5iTCygo2eo8SY-2nTmhvvtcg-n1aW4ZCTskAHSKkPnOiI6kDf_3FCFckibZzgHdM=>