From owner-cvs-all@FreeBSD.ORG Fri Jan 27 03:15:04 2006 Return-Path: X-Original-To: cvs-all@FreeBSD.ORG Delivered-To: cvs-all@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2316C16A420 for ; Fri, 27 Jan 2006 03:15:04 +0000 (GMT) (envelope-from csjp@FreeBSD.org) Received: from ems01.seccuris.com (ems01.seccuris.com [204.112.0.35]) by mx1.FreeBSD.org (Postfix) with SMTP id 5418B43D4C for ; Fri, 27 Jan 2006 03:15:02 +0000 (GMT) (envelope-from csjp@FreeBSD.org) Received: (qmail 43753 invoked by uid 0); 27 Jan 2006 03:19:11 -0000 Received: from unknown (HELO ?10.0.0.121?) (unknown) by unknown with SMTP; 27 Jan 2006 03:19:11 -0000 Message-ID: <43D99036.3010102@FreeBSD.org> Date: Thu, 26 Jan 2006 21:15:02 -0600 From: "Christian S.J. Peron" User-Agent: Mozilla Thunderbird 1.0.7 (Macintosh/20050923) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Jason Evans References: <200601270236.k0R2ai2x067283@repoman.freebsd.org> <20060127025150.GA57825@nagual.pp.ru> <6B47D688-0A7D-421F-9830-9493EC375307@FreeBSD.ORG> In-Reply-To: <6B47D688-0A7D-421F-9830-9493EC375307@FreeBSD.ORG> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: cvs-src@FreeBSD.ORG, src-committers@FreeBSD.ORG, Andrey Chernov , cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/lib/libc/stdlib malloc.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Jan 2006 03:15:04 -0000 Jason Evans wrote: > On Jan 26, 2006, at 6:51 PM, Andrey Chernov wrote: > >> I worry about my system performance. Could you please make all >> statistics >> and debug code conditional, debending on some flags which could be >> set as >> malloc options? Even in case this is a test period now, some people >> perhaps don't want some tests. It is much easy to turn some tests >> off via >> malloc options than to comment out manually corresponding malloc.c >> defines >> after each cvsup. > > > Unfortunately, run-time checks for the debugging features are > expensive, since the debugging code is scattered throughout > malloc.c. This pretty much mandates compile-time configuration, for > performance reasons. > > I can disable statistics and debugging, if there's a general > consensus to do so. How much performance difference is the debug/ > stats code making for you? I've only been disabling debug/stats for > benchmarking purposes, so I don't have a good feel for how much it > impacts overall system performance. These malloc debugging/stats features have been invaluable. I vote to accept the performance hit in exchange for useful debugging/stats features in -CURRENT, and disable them in -STABLE/-RELEASE when they are ready. -- Christian S.J. Peron csjp@FreeBSD.ORG FreeBSD Committer FreeBSD Security Team