From owner-svn-ports-head@freebsd.org  Thu Jan 17 15:35:30 2019
Return-Path: <owner-svn-ports-head@freebsd.org>
Delivered-To: svn-ports-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 35B29149A772;
 Thu, 17 Jan 2019 15:35:30 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 server-signature RSA-PSS (4096 bits)
 client-signature RSA-PSS (4096 bits) client-digest SHA256)
 (Client CN "freefall.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id BE1FC6CF14;
 Thu, 17 Jan 2019 15:35:29 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1033)
 id 9CACE169B0; Thu, 17 Jan 2019 15:35:29 +0000 (UTC)
Date: Thu, 17 Jan 2019 15:35:29 +0000
From: Alexey Dokuchaev <danfe@freebsd.org>
To: Roman Bogorodskiy <bogorodskiy@gmail.com>
Cc: Roman Bogorodskiy <novel@freebsd.org>, ports-committers@freebsd.org,
 svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject: Re: svn commit: r490566 - head/security/libgpg-error
Message-ID: <20190117153529.GA66383@FreeBSD.org>
References: <201901171510.x0HFARe1071897@repo.freebsd.org>
 <20190117151304.GA52967@FreeBSD.org>
 <20190117152242.GB1604@kloomba>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190117152242.GB1604@kloomba>
User-Agent: Mutt/1.10.1 (2018-07-13)
X-Rspamd-Queue-Id: BE1FC6CF14
X-Spamd-Bar: ------
Authentication-Results: mx1.freebsd.org
X-Spamd-Result: default: False [-6.92 / 15.00];
 NEURAL_HAM_MEDIUM(-1.00)[-1.000,0];
 NEURAL_HAM_SHORT(-0.92)[-0.919,0]; REPLY(-4.00)[];
 NEURAL_HAM_LONG(-1.00)[-1.000,0]
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-head>, 
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 17 Jan 2019 15:35:30 -0000

On Thu, Jan 17, 2019 at 07:22:44PM +0400, Roman Bogorodskiy wrote:
> > On Thu, Jan 17, 2019 at 03:10:27PM +0000, Roman Bogorodskiy wrote:
> > > New Revision: 490566
> > > URL: https://svnweb.freebsd.org/changeset/ports/490566
> > > 
> > > Log:
> > >   security/libgpg-error: update to 1.34
> > >   
> > >   Also, move USES to pet portlint.
> > > 
> > > ...
> > > @@ -14,10 +14,11 @@ LICENSE_COMB=	multi
> > >  LICENSE_FILE_GPLv2=	${WRKSRC}/COPYING
> > >  LICENSE_FILE_LGPL21=	${WRKSRC}/COPYING.LIB
> > >  
> > > +USES=		gmake libtool tar:bzip2
> > > +
> > >  OPTIONS_DEFINE=	DOCS NLS
> > >  OPTIONS_SUB=	yes
> > >  
> > > -USES=		gmake libtool tar:bzip2
> > >  USE_LDCONFIG=		yes
> > >  GNU_CONFIGURE=		yes
> > 
> > Looks like you should've moved the OPTIONS block instead.
> 
> Yes, just checked PH, you're correct. Though portlint didn't
> complain about that.

portlint(1) is just a mere linter, it can catch simple mistakes but
situations when entire block is misplaced is out of its scope.

> I'll fix it with the next update.

Thanks; it is a minor issue and does not warrant a separate commit.

./danfe