From owner-freebsd-bugs@freebsd.org  Sun Sep 17 16:52:23 2017
Return-Path: <owner-freebsd-bugs@freebsd.org>
Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id CEBFCE1DC92
 for <freebsd-bugs@mailman.ysv.freebsd.org>;
 Sun, 17 Sep 2017 16:52:23 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from kenobi.freebsd.org (kenobi.freebsd.org
 [IPv6:2001:1900:2254:206a::16:76])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id BD6DF65081
 for <freebsd-bugs@FreeBSD.org>; Sun, 17 Sep 2017 16:52:23 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from bugs.freebsd.org ([127.0.1.118])
 by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v8HGqNaH067289
 for <freebsd-bugs@FreeBSD.org>; Sun, 17 Sep 2017 16:52:23 GMT
 (envelope-from bugzilla-noreply@freebsd.org)
From: bugzilla-noreply@freebsd.org
To: freebsd-bugs@FreeBSD.org
Subject: [Bug 222375] [linux][linsysfs] Support for libdrm/Mesa
Date: Sun, 17 Sep 2017 16:52:24 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: Base System
X-Bugzilla-Component: kern
X-Bugzilla-Version: CURRENT
X-Bugzilla-Keywords: patch
X-Bugzilla-Severity: Affects Only Me
X-Bugzilla-Who: cem@freebsd.org
X-Bugzilla-Status: New
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: ---
X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-222375-8-KgYu2NzJgh@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-222375-8@https.bugs.freebsd.org/bugzilla/>
References: <bug-222375-8@https.bugs.freebsd.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs/>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 17 Sep 2017 16:52:23 -0000

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D222375

--- Comment #1 from Conrad Meyer <cem@freebsd.org> ---
Patch mostly looks good to me.

I'd remove the useless comments above fillers for the simple
data/device/vendor/etc ones (but keep for uevent_foo and vgapci).

I'd replace strncpy() in linsysfs_fill_vgapci with strlcpy().  I don't think
this routine behaves correctly at the limit due to strncpy() and the "%s"
format string use.

(Also, strncpy() unnecessarily zero-fills the remainder of the buffer, which
isn't needed on every loop iteration.)

This module should use its own malloc type, rather than M_TEMP, but that
matches the existing pattern so it doesn't need to be changed.

Indentation seems funky on line 351 in the new file, but that might just be
bugzilla.

MAXPATHLEN is hugely excessive for chardevname.

--=20
You are receiving this mail because:
You are the assignee for the bug.=