From owner-freebsd-current@freebsd.org Fri Aug 25 12:54:09 2017 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9CBBBDD7FB5 for ; Fri, 25 Aug 2017 12:54:09 +0000 (UTC) (envelope-from ed@nuxi.nl) Received: from mail-yw0-x234.google.com (mail-yw0-x234.google.com [IPv6:2607:f8b0:4002:c05::234]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 57AF469E for ; Fri, 25 Aug 2017 12:54:09 +0000 (UTC) (envelope-from ed@nuxi.nl) Received: by mail-yw0-x234.google.com with SMTP id x21so12395224ywg.2 for ; Fri, 25 Aug 2017 05:54:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuxi-nl.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=RIu2rjYI7wcozGH8zPBapRW1RXz24zKOdJ0SEla9VO0=; b=VGSa58wBffidV+vkXuVAs7kQ3orFskTbPu5WSJVn+GeOPGZ0sl6OS+9VIUSRCpKPRm 6XY3g+0vvg8N/bdl10M9IODLxGR/jGKwxZ7GEooeDWPzF3bOZnnb0OQGsrOxMivNjyOe w1joFEQ7JZ7Zy4pkcvdcTr2ukO+J+jUgm/F/Zq4jswabyGL5FWwg9jHDlkxpyFUXEEp8 Jp1IB+3D/b4+WdmiNV0jmHHL4KwNPge3ENtTcGdjP/yOd7WRWVhP/qfWw3vlPJnhG9wv Nax1IkkAHwooSTXdS5C/I1/dNQVMvjXKFv6KY+c+MDuEEYXXY5PoFdkNNYt2vwRWjAH5 ecYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=RIu2rjYI7wcozGH8zPBapRW1RXz24zKOdJ0SEla9VO0=; b=ILCtMD2N7wrptruRZJ7rBWFSAzsZAqiLurmJLKnSNMAivnoBgdUMYNupT3umYCvMOr oVaAUW45glDgVeEDW0FfpusDiQt291GtXSotGtIRwpkprK7AyJw1LIB9ikLUvKAazkgn q4a/rS26XhhByImw6A0JXoDJfp/a3lR25CjOhz23h8Chz99/xreZcCMM5R+dfP++EdvC 8qiauY7SODzi2D9K1kDevAV4Zh3FcTZ/dy8vzoC04etUYdYSkwrFKeBEkCGHR7yIh5Qk WjWRsg/m4B/xqdkP9scMCM3qEno9jnR60NE3kIplMHJAAvj0pGO8R8ZXJib/hKA3MJw3 kLGg== X-Gm-Message-State: AHYfb5jO1XFcmIBOJG7++/9PYDV6wNpcNZFnifQ2qHM0j4KsEXVUIA0z 8F8aXlH0Yax1WVKMCp4Cta8isYIs7yY0WWY= X-Received: by 10.129.84.6 with SMTP id i6mr8156070ywb.203.1503665648453; Fri, 25 Aug 2017 05:54:08 -0700 (PDT) MIME-Version: 1.0 Received: by 10.13.227.193 with HTTP; Fri, 25 Aug 2017 05:53:37 -0700 (PDT) In-Reply-To: References: <1C5A448F-C91A-4599-8500-E4E46E6F5205@dsl-only.net> From: Ed Schouten Date: Fri, 25 Aug 2017 14:53:37 +0200 Message-ID: Subject: Re: svn commit: r322875 - head/sys/dev/nvme To: Mark Millard Cc: David Chisnall , Warner Losh , svn-src-head@freebsd.org, FreeBSD Current , FreeBSD-STABLE Mailing List , freebsd-hackers Content-Type: text/plain; charset="UTF-8" X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Aug 2017 12:54:09 -0000 2017-08-25 9:46 GMT+02:00 Mark Millard : > It appears that at least 11.1-STABLE -r322807 does not handle > -std=c++98 styles of use of _Static_assert for g++7 in that > g++7 reports an error: Maybe we need to do something like this? Index: sys/sys/cdefs.h =================================================================== --- sys/sys/cdefs.h (revision 322887) +++ sys/sys/cdefs.h (working copy) @@ -294,7 +294,7 @@ #if (defined(__cplusplus) && __cplusplus >= 201103L) || \ __has_extension(cxx_static_assert) #define _Static_assert(x, y) static_assert(x, y) -#elif __GNUC_PREREQ__(4,6) +#elif __GNUC_PREREQ__(4,6) && !defined(__cplusplus) /* Nothing, gcc 4.6 and higher has _Static_assert built-in */ #elif defined(__COUNTER__) #define _Static_assert(x, y) __Static_assert(x, __COUNTER__) -- Ed Schouten Nuxi, 's-Hertogenbosch, the Netherlands KvK-nr.: 62051717