From owner-svn-src-projects@FreeBSD.ORG Mon Dec 1 06:51:12 2014 Return-Path: Delivered-To: svn-src-projects@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 02D47F51; Mon, 1 Dec 2014 06:51:12 +0000 (UTC) Received: from mail-wi0-x232.google.com (mail-wi0-x232.google.com [IPv6:2a00:1450:400c:c05::232]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 847D19DA; Mon, 1 Dec 2014 06:51:11 +0000 (UTC) Received: by mail-wi0-f178.google.com with SMTP id hi2so16187223wib.5 for ; Sun, 30 Nov 2014 22:51:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type:content-transfer-encoding; bh=RXpsEyvzvSuY1/UZnh3+fhoWm65r3xHXJ8/G+i3w+24=; b=G2oW64C9B2f61Gzy7NtUuKWzncmxiJYltEL2TC4IhZf5jDAzZrigcgEFfQHR5zfF2X umJplYcB9ypV0rMmTtPgJbl1loX8EBUg8PJ5koujBDhm+EOLVbOmavLj2dARsMNMc4mS EwO+K894MXJJGSmw+W9UGvEnHhXxbWVYS+YvUgogFgoBMDcmULeWYQGf9orwCx3q241D RQzGm7gkUHjtnSdNe99Xp1q/Zq4b+zTge4D1T61t2jpJc6cLlZK1L9cWB16xzZgcQrex PtlHRAEaKZERqodmcAEcon+KaY0HngB9ZJfuyoekQnNyYLjPdO/+jbR/lA7TS5hy9y6+ tWHQ== MIME-Version: 1.0 X-Received: by 10.194.24.103 with SMTP id t7mr71303730wjf.15.1417416669950; Sun, 30 Nov 2014 22:51:09 -0800 (PST) Sender: adrian.chadd@gmail.com Received: by 10.216.106.195 with HTTP; Sun, 30 Nov 2014 22:51:09 -0800 (PST) In-Reply-To: References: <201411282207.sASM7Gq7055794@svn.freebsd.org> <20141130202521.GA1103@stack.nl> Date: Sun, 30 Nov 2014 22:51:09 -0800 X-Google-Sender-Auth: 2_nqwJ-21kuaDJLvG6wZ2MaEoII Message-ID: Subject: Re: svn commit: r275219 - projects/building-blocks/share/skel From: Adrian Chadd To: Garrett Cooper Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: svn-src-projects@freebsd.org, "src-committers@freebsd.org" , Garrett Cooper , Jilles Tjoelker X-BeenThere: svn-src-projects@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the src " projects" tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Dec 2014 06:51:12 -0000 .. is vi marked as a tool required for building (ie, ex) ? -a On 30 November 2014 at 20:27, Garrett Cooper wrote: > On Nov 30, 2014, at 12:25, Jilles Tjoelker wrote: > >> On Fri, Nov 28, 2014 at 10:07:16PM +0000, Garrett Cooper wrote: >>> Author: ngie >>> Date: Fri Nov 28 22:07:16 2014 >>> New Revision: 275219 >>> URL: https://svnweb.freebsd.org/changeset/base/275219 >> >>> Log: >>> Install skeleton files based on the values of MK_MAIL and MK_TCSH >> >>> Customize according to MK_GAMES and MK_VI, in particular comment out l= ines >>> that would change behavior >> >>> Change dot.cshrc and dot.profile to not check for /usr/games/fortune b= ased >>> on the new behavior in customizing the files >> >> Hmm, this assumes a rather specific use case: selecting a particular >> combination of options, building everything and installing everything >> what was built. >> >> In particular, the run-time check for /usr/games/fortune was there >> because a user might not install /usr/games, even though it was part of >> the built release. With "packaged base", this possibility will remain >> important. > > Good point. > > What triggered this commit was something I noticed when I fixed =E2=80=9C= MK_VI =3D=3D no=E2=80=9D to delete vi in base, which in turn breaks the def= ault dot files, i.e. 'export EDITOR=3Dvi=E2=80=99. MK_VI =3D=3D no doesn=E2= =80=99t install vi with installworld, but it doesn=E2=80=99t clean it up on= head if you run make delete-old either, so this issue wasn=E2=80=99t appar= ent until I started this work (and I guess no one complained about the MK_V= I =3D=3D no case before now). To err on the safe side, I can add a `if [ -x= /usr/bin/vi ]; then ; fi` around the export EDITOR line if you like =E2=80= =94 however many other OS distros (Fedora Linux, IllumOS, Ubuntu Linux, etc= ) don=E2=80=99t ship with defaults =E2=80=94 is this something we should do= as well? > > vi is also implicitly required for the build when building some files in = share/termcap, as the build calls ex on the files, but that=E2=80=99s a sid= enote. > >> Also, dotfiles might be shared between systems by users. > > Yes, but shouldn=E2=80=99t the person customizing the system know what fi= les are being distributed? > >> This is an objection against customizing dot.* file contents depending >> on options, not against conditionally installing dot.* files. > > Ok. Something else that needs to be discussed is /usr/games being in $PAT= H and a few other things, because this could slow down path lookups, even i= f it=E2=80=99s a small amount (I realize the namei cache is supposed to mak= e this less noticeable, but every little bit counts IMHO). > > Thanks for the input :)!