From owner-freebsd-current Wed May 7 12:40:36 1997 Return-Path: Received: (from root@localhost) by hub.freebsd.org (8.8.5/8.8.5) id MAA10630 for current-outgoing; Wed, 7 May 1997 12:40:36 -0700 (PDT) Received: from sos.freebsd.dk (sos.freebsd.dk [195.8.129.33]) by hub.freebsd.org (8.8.5/8.8.5) with ESMTP id MAA10621 for ; Wed, 7 May 1997 12:40:32 -0700 (PDT) Received: (from sos@localhost) by sos.freebsd.dk (8.8.5/8.7.3) id VAA02884; Wed, 7 May 1997 21:40:28 +0200 (MEST) From: Søren Schmidt Message-Id: <199705071940.VAA02884@sos.freebsd.dk> Subject: Re: #include problem breaks current In-Reply-To: <199705071914.VAA25645@bitbox.follo.net> from Eivind Eklund at "May 7, 97 09:14:41 pm" To: eivind@bitbox.follo.net (Eivind Eklund) Date: Wed, 7 May 1997 21:40:28 +0200 (MEST) Cc: roberto@keltia.freenix.fr, freebsd-current@FreeBSD.ORG X-Mailer: ELM [version 2.4ME+ PL30 (25)] MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit Sender: owner-current@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk In reply to Eivind Eklund who wrote: > > > > make world is failing in libc, probably because of changes in #include by > > the following commit: > > I've backed out that part of the change. I thought a make world > wasn't necessary to test this change (I did quite a few other tests), > but obviously I was wrong. A clean run through a make world is a requirement before committing changes!, errors can happen of cause, but at least it should be tested :( > I'm doing makes of other parts of the system right now to see if more > of it need to be backed out; I'll do a 'make world' as soon as I've > tested the most relevant parts (to find possible other problems as > quickly as possible.) Back it out entirely! and come back when a make world completes without errors. Excuse my harsh fashion, but I think dicipline in this respect is paramount, we can all make error's (I'm known to have done my part :) ) but we should at least check it to the best of ones abilities... -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- Søren Schmidt (sos@FreeBSD.org) FreeBSD Core Team Even more code to hack -- will it ever end ..