From owner-cvs-all@FreeBSD.ORG Mon Aug 6 04:07:12 2007 Return-Path: Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0D23D16A41A for ; Mon, 6 Aug 2007 04:07:12 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from mail2.fluidhosting.com (mx22.fluidhosting.com [204.14.89.5]) by mx1.freebsd.org (Postfix) with SMTP id AB63713C45D for ; Mon, 6 Aug 2007 04:07:11 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: (qmail 13181 invoked by uid 399); 6 Aug 2007 04:07:10 -0000 Received: from localhost (HELO lap.dougb.net) (dougb@dougbarton.us@127.0.0.1) by localhost with ESMTP; 6 Aug 2007 04:07:10 -0000 X-Originating-IP: 127.0.0.1 Message-ID: <46B69E6C.7020108@FreeBSD.org> Date: Sun, 05 Aug 2007 21:07:08 -0700 From: Doug Barton Organization: http://www.FreeBSD.org/ User-Agent: Thunderbird 2.0.0.6 (X11/20070803) MIME-Version: 1.0 To: Marcelo Araujo References: <200708052014.l75KE3xi051192@repoman.freebsd.org> In-Reply-To: <200708052014.l75KE3xi051192@repoman.freebsd.org> X-Enigmail-Version: 0.95.1 OpenPGP: id=D5B2F0FB Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: cvs-ports@FreeBSD.org, Hugo Saro , cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/net/haproxy-devel/files haproxy.in haproxy.sh.in X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Aug 2007 04:07:12 -0000 Marcelo Araujo wrote: > araujo 2007-08-05 20:14:02 UTC > > FreeBSD ports repository > > Added files: > net/haproxy-devel/files haproxy.in > Removed files: > net/haproxy-devel/files haproxy.sh.in > Log: > - Forgot the new RC script by last commit! > > PR: ports/112934 http://www.FreeBSD.org/cgi/query-pr.cgi?pr=112934 > Approved by: pav (portmgr, in mentor's absence) > > Revision Changes Path > 1.1 +50 -0 ports/net/haproxy-devel/files/haproxy.in (new) > 1.2 +0 -50 ports/net/haproxy-devel/files/haproxy.sh.in (dead) > > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/net/haproxy-devel/files/haproxy.in > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/net/haproxy-devel/files/haproxy.sh.in Always glad to see a new and improved rc.d script. :) A few comments, hopefully to be seen as constructive criticism. 1. You might want to look at the style guide at http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/rc-scripts.html for some general tips, particularly about how the default options are set. The way you do it isn't "wrong," it's just not as efficient as it could be. Also the load_rc_config line should go above the default settings. 2. Is there a reason that this script needs BEFORE: DAEMON? From the pkg-descr it looks like this might be reasonable, I just want to be sure it's been thought out. 3. PREFIX is subbed out in the required_files= line, but not in the default flags, FYI. Also, since it looks like those two command line opts aren't really optional, so you might be better off placing them in command_args instead. 4. Minor style issue, the sig_gracefulstop variable is probably overkill, since you only use the value once. 5. Last minor style note, extra_commands is usually placed at the top of the file near the command to make it easier to see. I know this is a lot of notes, so I want to make clear that overall the script is fine, these are just some suggestions to hopefully make it a little better. Regards, Doug -- This .signature sanitized for your protection