From owner-svn-ports-all@freebsd.org Fri Jan 5 20:37:06 2018 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 62DE5EBF375; Fri, 5 Jan 2018 20:37:06 +0000 (UTC) (envelope-from tcberner@gmail.com) Received: from mail-qt0-f176.google.com (mail-qt0-f176.google.com [209.85.216.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 066E57D28B; Fri, 5 Jan 2018 20:37:06 +0000 (UTC) (envelope-from tcberner@gmail.com) Received: by mail-qt0-f176.google.com with SMTP id k19so7196820qtj.6; Fri, 05 Jan 2018 12:37:05 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=2dV3JhwR376DVSdkFiIuXwfdz0wkoDiKDlX8qwb6oU4=; b=ZSw9+/TX7tLAesyaGH75dUiAfDZpYeS38jjO09JuPjjvrL/3Baj+LiFJk0NA7hJPM+ P2tS7scLVE7+TaVbTmnF0sRtGT+6X+xNv3vvrCl560Ta8w7XyosFyrue0lqGTX8dYxcs NW1x+Q/1RGz+LLhzNIR+LOCbOOctr3UHu3/K/SktVLUBBT7pCJJpEpY4i8qgUyPNVHj2 MtRFNU73mxa6ccwq1aWXHsBueoUN5YWjPn/nCBFrpOejgWKSdlMq8HVeRL6ZUdBM+wrn wxKB9Pjo2ALDMik3xrZjFJtmQMCKGmp9Q4Uns8xVRDMKj97peimAPoF0lTk8LQZzRicv /BTg== X-Gm-Message-State: AKwxytfxw7CA8EDunXxSPN0tIYqwNPuM/k37JCwYQisE7gCnTS+yzNAq k+q6k71LjTB7ZKbVnW+J4bcX2TtL X-Google-Smtp-Source: ACJfBot4PtX1/p1Svm62BzXbWSfZDmZlCF5Zp4984bxJDdgNGCOFBFNICC598qm03pSojrCNb4sYUw== X-Received: by 10.237.60.83 with SMTP id u19mr5525978qte.190.1515184619073; Fri, 05 Jan 2018 12:36:59 -0800 (PST) Received: from mail-qt0-f176.google.com (mail-qt0-f176.google.com. [209.85.216.176]) by smtp.gmail.com with ESMTPSA id s78sm4144686qke.68.2018.01.05.12.36.58 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 05 Jan 2018 12:36:58 -0800 (PST) Received: by mail-qt0-f176.google.com with SMTP id a16so7182235qtj.3; Fri, 05 Jan 2018 12:36:58 -0800 (PST) X-Received: by 10.200.56.234 with SMTP id g39mr5981519qtc.209.1515184618518; Fri, 05 Jan 2018 12:36:58 -0800 (PST) MIME-Version: 1.0 Received: by 10.200.51.199 with HTTP; Fri, 5 Jan 2018 12:36:58 -0800 (PST) In-Reply-To: <87c9a0b1-f7ab-83ef-cdb1-f5931196b6c9@rawbw.com> References: <201801021649.w02GnOap052049@repo.freebsd.org> <87c9a0b1-f7ab-83ef-cdb1-f5931196b6c9@rawbw.com> From: "Tobias C. Berner" Date: Fri, 5 Jan 2018 21:36:58 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r457914 - in head: . Mk/Uses astro/kstars audio/csound6 biology/iqtree cad/freecad cad/openscad deskutils/kdeplasma-addons editors/calligra games/xptools graphics/code-eli graphics/colm... To: Yuri Cc: "Tobias C. Berner" , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Jan 2018 20:37:06 -0000 Hi Yuri, 1) It only checks against valid versions 2,3, and is happy as long as it gets exactly one of them. Yes, you're right I could/should probably add a check so that it only accepts "2 3 build run". 2) I think that's the normal terminology :) - also :run_only would be a bit of a clutch to write, even if it were more explicit. 3) Technically yes, but I'd say it makes it a bit too over-engineered. :) mfg Tobias On 2 January 2018 at 19:51, Yuri wrote: > On 01/02/18 08:49, Tobias C. Berner wrote: > >> Usage: >> USES=eigen:[,] >> version: 2 or 3 (required) >> type: build (default), run >> > > > I have 3 questions: > > > 1. Why doesn't eigen.mk check for invalid argument values? For example, > USES=eigen:3,4,build,run doesn't cause an error as it should. I had the > same question about other USES modules, but am asking here because > eigen.mk is freshly added. It seems like checking for invalid values can > be a good idea? > > > 2. Maybe it would be beneficial to explain in the module when particular > arguments should be used: > > USES=eigen:{2,3} (defaults to build) - should be used when the port uses > Eigen headers during build, but doesn't install any headers that depend on > Eigen > > USES=eigen:{2,3},run - should be used when the port doesn't use Eigen > during build, but installs headers that depend on Eigen > > USES=eigen:{2,3},build,run - should be used when the port both uses Eigen > during build, and installs headers that depend on Eigen > > It might not be obvious that 'run' should be used when the installed > headers use it. > > > 3. Maybe USES=eigen:{2,3},build should conflict with NO_BUILD=yes, as > these are incompatible conditions? It seems like this could easily catch > some mistakes. > > > Thanks, > > Yuri > > >