From owner-cvs-src@FreeBSD.ORG Thu Dec 28 06:10:36 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 4791A16A40F; Thu, 28 Dec 2006 06:10:36 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (66-23-211-162.clients.speedfactory.net [66.23.211.162]) by mx1.freebsd.org (Postfix) with ESMTP id E240F13C470; Thu, 28 Dec 2006 06:10:35 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from zion.baldwin.cx (zion.baldwin.cx [192.168.0.7]) (authenticated bits=0) by server.baldwin.cx (8.13.6/8.13.6) with ESMTP id kBS6ATI1061418; Thu, 28 Dec 2006 01:10:34 -0500 (EST) (envelope-from jhb@freebsd.org) From: John Baldwin To: "David O'Brien" Date: Thu, 28 Dec 2006 01:10:24 -0500 User-Agent: KMail/1.9.4 References: <200612160919.54708.jhb@freebsd.org> In-Reply-To: <200612160919.54708.jhb@freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200612280110.25216.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [192.168.0.1]); Thu, 28 Dec 2006 01:10:34 -0500 (EST) X-Virus-Scanned: ClamAV 0.88.3/2386/Wed Dec 27 13:32:31 2006 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: cvs-src@freebsd.org, src-committers@freebsd.org, mjacob@freebsd.org, cvs-all@freebsd.org, John Polstra Subject: Re: cvs commit: src/sys/dev/bge if_bge.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Dec 2006 06:10:36 -0000 On Saturday 16 December 2006 09:19, John Baldwin wrote: > On Friday 15 December 2006 20:42, John Polstra wrote: > > On 15-Dec-2006 David O'Brien wrote: > > > On Fri, Dec 15, 2006 at 01:26:55PM -0800, Peter Grehan wrote: > > >> >I have a Tyan K8W (s2885) which I experienced this on: > > >> > > >> That's using the the AMD 8131 right ? > > > > > > Yep. > > > > > >> Known not to support MSI. > > > > > > I assumed the code would check and not attempt MSI if not supported. > > > > That would be the job of the PCI infrastructure, not of the bge > > driver. Quite a few motherboards/chipsets indicate MSI support > > in their PCI configuration registers but do not in fact have > > working MSI support. Scott and I recently added quirk support in > > sys/dev/pci/pci.c to deal with that. Feel free to add a new entry > > there. > > But I have a separate patch for the 8131 as it is treated differently. > Please try http://www.FreeBSD.org/~jhb/patches/msi_pcib.patch Can someone with a system with an AMD 8131 HT-PCIX bridge please test this patch? I know Matt (cc'd) has one and I think David has one. The patch should disable MSI for any devices behind the 8131 bridge, but not necessarily all devices in the system. -- John Baldwin