From owner-freebsd-ports@FreeBSD.ORG Sun Feb 2 10:51:37 2014 Return-Path: Delivered-To: freebsd-ports@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 3551CE49 for ; Sun, 2 Feb 2014 10:51:37 +0000 (UTC) Received: from mout.gmx.net (mout.gmx.net [212.227.15.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id C37C812A8 for ; Sun, 2 Feb 2014 10:51:36 +0000 (UTC) Received: from [192.168.0.100] ([87.139.233.65]) by mail.gmx.com (mrgmx001) with ESMTPSA (Nemesis) id 0LzblK-1VEM0A2ggk-014n7s for ; Sun, 02 Feb 2014 11:51:28 +0100 Message-ID: <52EE2337.9080809@gmx.de> Date: Sun, 02 Feb 2014 11:51:35 +0100 From: olli hauer User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: "freebsd-ports@freebsd.org" Subject: Re: bsd.apache.mk Malformed conditional when APACHE_VERSION defined References: <52EE0BD3.8000006@heuristicsystems.com.au> In-Reply-To: <52EE0BD3.8000006@heuristicsystems.com.au> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:+gxPbJnojixdQDPf136BOiNhTBw18FWU588osKa6hfhJjKgkBNB kLtZQU8O99PAFF8KXd9R5QdPc6q7EdxXEN00+Y0yZfC5aOsKeHgEJ4O0L/X4fD2KGMnehLL ayPDQOMoGaAYbp1ZF/zY2c2AMyvY1oucicMIoYcDbaRFhdJwiC+lCxMrbFsrma9LWYC26yd +yLHzsXZwEixJmFFr9I+w== Cc: Dewayne Geraghty X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 02 Feb 2014 10:51:37 -0000 On 2014-02-02 10:11, Dewayne Geraghty wrote: > I filed a PR against textproc/htdig which should really be against the > ports systems. > > Would someone be kind enough to advise the current method to specify the > apache version. In ports.conf, I currently use > USE_APACHE=22 | APACHE_VERSION=22 > to specify the required version of apache for: > textproc/htdig > www/mod_security > lang/php5 > > I believe this PR > > http://www.freebsd.org/cgi/query-pr.cgi?pr=186364 > > which probably should be routed to the ports system, and not textproc/htdig > > The error is: > cd /usr/ports/textproc/htdig && make -V UNIQUENAME > "/usr/ports/Mk/bsd.apache.mk", line 306: warning: String comparison > operator should be either == or != > "/usr/ports/Mk/bsd.apache.mk", line 306: Malformed conditional > (!empty(_APACHE_VERSION_MINIMUM) && (${_APACHE_VERSION} < > ${_APACHE_VERSION_MINIMUM})) > "/usr/ports/Mk/bsd.port.mk", line 6603: if-less endif > make: fatal errors encountered -- cannot continue > > which goes away if APACHE_VERSION isn't used, eg. > cd /usr/ports/textproc/htdig && make __MAKE_CONF=/dev/null -V UNIQUENAME > htdig > Hi Dewayne, APACHE_VERSION is a read only variable in case a port needs to know the installed / default Apache version -> do not set this variable! In case you want to specify a default apache use in etc/make.conf for example APACHE_PORT=www/apache22 See lines 12 - 25 in Mk/bsd.apache.mk -- Regards, olli