From nobody Fri Feb 6 17:56:07 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4f71x000Gvz6RVqv for ; Fri, 06 Feb 2026 17:56:20 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-qk1-f182.google.com (mail-qk1-f182.google.com [209.85.222.182]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4f71wz3kphz4KBn for ; Fri, 06 Feb 2026 17:56:19 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-qk1-f182.google.com with SMTP id af79cd13be357-8c70ab3b5fcso128467185a.2 for ; Fri, 06 Feb 2026 09:56:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1770400579; cv=none; d=google.com; s=arc-20240605; b=TFilP1/12bflM+nQSua6qoN9qmkOOanhIR2HiCNSJeCnIUrxMBRi9QeipPFQaSQOMr 8zyi4MWwJEsxAkOHMy7BJYupQlApruRaPEh+HP5/tEv4oDzzGktSArzzJUPgxq8/W9gv x+pSpXWtpqhdq1esbJH5hTaizmO7+uG64ium+akryvui2J/qgyrJt0y6nvWWveHUDof9 hyg3XqhgpEIatDrGgLbZy0DarJj+UXgfMhZwFYgPDCa2e6G74XOwwWbTW8dWI8P/THMx Ws+8TS7TRGyOIyZlnE+OQHcGO/O5WZguFj1TYkNv0pjbvF2073h1S0uN/Zi76Y36ILab E8IQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version; bh=cQ4qTzV/0YDEIwCIGfsx2A4Xn+eCfp171+P6YjD9E6k=; fh=Udp3t/OQMqqrWuifn4cetIGqFim0axqCAZf7z1zPHM0=; b=ZkdJwiEUUbpne1qoLFDXjo+J/ZJ9yHT7M4IKA2eWB4gnxxmO2khCLgqMX0YCk9vb5Z +TiSB1IQ928V4n/FAPhrSZvQBPQSnjHjPSSxyVke+P6OFKhUXWu7EmzHi8P0fFmqH4rz WhIrZ2BkAyAnWYZYAY+A0mnE6Dks6s2dyx2Td0GJC6L+v7pSWRx8zU/UgOglXFPesae3 fzgFZJ23EcZwozb/t5vOf3OVilsltQ4jJBDT2sY29kmyp3YEFISiPuVYSQHg0VzDk3k/ HQcZdGpV6nN6X7s7eCElamx+40GC7UZawUqXk6KqnNQiXqoWAiRGfsaZz6QYt1KD/78a 0LsQ==; darn=freebsd.org ARC-Authentication-Results: i=1; mx.google.com; arc=none X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770400579; x=1771005379; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=cQ4qTzV/0YDEIwCIGfsx2A4Xn+eCfp171+P6YjD9E6k=; b=EknpL8Dz47jy/5zYMzGf7nNkupYqSSQuYzgSt5hT4WciNR60deb2EGKciGKUYF2mup zSIhNQSbppNvVZ8YqUWUGn8ijd6iaWosofuqBn/dESi2UZsuO1l3OIogW7vdoN4bkoTV kdtYgIdqMkylnGgaYSpv9ctvKOYuiDGRX3wStOA1od7YuJTl9GPuFv6SKBmG4BL4J/dM Ec+nsqvP4aaCHpi4r8yxV7oCqNSmAKMaoSHNC2F9BYUo3lCvxS7nazxRVCcg1ZWJfP+n WN0vXPdOzXvJDbR297Ceh8d+UbDtfWvQ9JEFVJOrdrii/B0LtqNK1xKPgihuu/LVFc0p GQog== X-Forwarded-Encrypted: i=1; AJvYcCXv5MJsdxDzh73pmWEt3Ah2zvJbcMjs7oR+WZjGA1OGVg7lNGwwu9kfwmywN4p3z6iSWqS814W5NBgZ5NLJMJFyBm61@freebsd.org X-Gm-Message-State: AOJu0YzZxa8TC7xFG4OlWxOTbKVm+TFrE3HbW3CQ699+peScl87zkC/J bLY9BFEPS9rLVq51UW1bENXkmMqM/8s6iPGK09hguUi7zpR7SN4zVgXTycwHfnMYrg/7WNibvMb kJRTiroSaSWp/ENAob91QJIkBm6O7hCw= X-Gm-Gg: AZuq6aI77cvucQwDD0ERY8yHAU7oU9DFaOD5OytiV7R/Qfd1uqnI/jy9DoqDPFE3ytP DtJQigk+/AbtE0+YRK62TBor1Mq/lLlvmJwAXlbFPVddnqt5QLvVslfuqnBUa9z1vnQRQbpaHbq N8NK+4AzDoz8Ev3rXSwXSRrigLrgKZPbwnXbQhic6Hc4kLldoiEFaDiY7ub6HzWGPu2YmHLSofy 1c21u0+5fR3qEXX2zu2Ib6A63b9CZ1eW+j/w71Ql96a7uOKpkQDacjbTwIF4kKg+TpbwlufFArB CiAqoCLS58BNbQyRY8yF5Q/+aqLcLg== X-Received: by 2002:a05:620a:40c5:b0:8b2:eea5:3311 with SMTP id af79cd13be357-8caef7e1788mr491246985a.26.1770400578619; Fri, 06 Feb 2026 09:56:18 -0800 (PST) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 References: <695f8abf.30bec.62a9009@gitrepo.freebsd.org> <11fddfa0-41fd-430a-8ecb-8afa27385878@FreeBSD.org> In-Reply-To: <11fddfa0-41fd-430a-8ecb-8afa27385878@FreeBSD.org> From: Adrian Chadd Date: Fri, 6 Feb 2026 09:56:07 -0800 X-Gm-Features: AZwV_QgVm5nVhz_gsTjtCvj4bSNcUxyyJGSan7L3GXkph1gbjD2pnfQxAxqAkz0 Message-ID: Subject: Re: git: c0df8f6f0e6a - main - acpi: Make taskqueue only run on BSP To: Kyle Evans Cc: Aymeric Wibo , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; TAGGED_FROM(0.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US] X-Rspamd-Queue-Id: 4f71wz3kphz4KBn X-Spamd-Bar: ---- oh, is this what's causing it? i've been seeing weird behaviour on my intel based MSI GE76 raider that aligns with this. Do we actually know that the BSP is always the CPU that woke up from ACPI? -adrian On Fri, 6 Feb 2026 at 07:59, Kyle Evans wrote: > > On 1/8/26 04:45, Aymeric Wibo wrote: > > The branch main has been updated by obiwac: > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=3Dc0df8f6f0e6a5f77ec9140e8= 075d09c55fe4c3c7 > > > > commit c0df8f6f0e6a5f77ec9140e8075d09c55fe4c3c7 > > Author: Aymeric Wibo > > AuthorDate: 2025-12-29 20:01:50 +0000 > > Commit: Aymeric Wibo > > CommitDate: 2026-01-08 10:35:54 +0000 > > > > acpi: Make taskqueue only run on BSP > > > > This is needed because when we add the suspend-to-idle loop, we on= ly > > want to break the BSP out of idle to process the taskqueue while k= eeping > > all the others idled. > > > > Currently assuming BSP to be CPU0, which may not always be the cas= e on > > non-x86. > > > > Reviewed by: kib > > Approved by: kib > > Sponsored by: The FreeBSD Foundation > > Differential Revision: https://reviews.freebsd.org/D54406 > > --- > > sys/dev/acpica/Osd/OsdSchedule.c | 6 +++++- > > 1 file changed, 5 insertions(+), 1 deletion(-) > > > > diff --git a/sys/dev/acpica/Osd/OsdSchedule.c b/sys/dev/acpica/Osd/OsdS= chedule.c > > index f0464709e8ad..0c5eadb87687 100644 > > --- a/sys/dev/acpica/Osd/OsdSchedule.c > > +++ b/sys/dev/acpica/Osd/OsdSchedule.c > > @@ -35,6 +35,7 @@ > > #include > > #include > > #include > > +#include > > #include > > #include > > #include > > @@ -109,10 +110,13 @@ static void > > acpi_taskq_init(void *arg) > > { > > int i; > > + /* XXX Currently assuming BSP is CPU0. */ > > + cpuset_t just_bsp =3D CPUSET_T_INITIALIZER(0x1); > > > > acpi_taskq =3D taskqueue_create_fast("acpi_task", M_NOWAIT, > > &taskqueue_thread_enqueue, &acpi_taskq); > > - taskqueue_start_threads(&acpi_taskq, acpi_max_threads, PWAIT, "acp= i_task"); > > + taskqueue_start_threads_cpuset(&acpi_taskq, acpi_max_threads, PWAI= T, > > + &just_bsp, "acpi_task"); > > if (acpi_task_count > 0) { > > if (bootverbose) > > printf("AcpiOsExecute: enqueue %d pending tasks\n", > > > > Hi, > > Mentioned privately, but also bringing it to the list in case anyone else= has had the same symptom- updating my frame.work laptop from ~December mai= n to ~February main resulted in a power-button wakeup shutting down the sys= tem after it wakes up. The result of a bisect pointed at this commit relia= bly causing it, and reverting it locally does seem to fix it. > > Thanks, > > Kyle Evans >