From owner-freebsd-scsi Mon Sep 23 13:24:20 2002 Delivered-To: freebsd-scsi@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 31A3637B401; Mon, 23 Sep 2002 13:24:19 -0700 (PDT) Received: from odin.ac.hmc.edu (Odin.AC.HMC.Edu [134.173.32.75]) by mx1.FreeBSD.org (Postfix) with ESMTP id A764843E42; Mon, 23 Sep 2002 13:24:18 -0700 (PDT) (envelope-from brdavis@odin.ac.hmc.edu) Received: from odin.ac.hmc.edu (IDENT:brdavis@localhost.localdomain [127.0.0.1]) by odin.ac.hmc.edu (8.12.3/8.12.3) with ESMTP id g8NKOFj1011937; Mon, 23 Sep 2002 13:24:15 -0700 Received: (from brdavis@localhost) by odin.ac.hmc.edu (8.12.3/8.12.3/Submit) id g8NKOFr2011936; Mon, 23 Sep 2002 13:24:15 -0700 Date: Mon, 23 Sep 2002 13:24:15 -0700 From: Brooks Davis To: Matt Jacob Cc: scsi@FreeBSD.org Subject: Re: cvs commit: src/sys/cam/scsi scsi_all.c Message-ID: <20020923132415.A24262@Odin.AC.HMC.Edu> References: <200209230456.g8N4uZSW013370@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-md5; protocol="application/pgp-signature"; boundary="ZGiS0Q5IWpPtfppv" Content-Disposition: inline User-Agent: Mutt/1.2.5.1i In-Reply-To: <200209230456.g8N4uZSW013370@freefall.freebsd.org>; from mjacob@FreeBSD.org on Sun, Sep 22, 2002 at 09:56:35PM -0700 X-Virus-Scanned: by amavisd-milter (http://amavis.org/) on odin.ac.hmc.edu Sender: owner-freebsd-scsi@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org --ZGiS0Q5IWpPtfppv Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Sep 22, 2002 at 09:56:35PM -0700, Matt Jacob wrote: > mjacob 2002/09/22 21:56:35 PDT >=20 > Modified files: > sys/cam/scsi scsi_all.c=20 > Log: > A SCSI_DELAY of zero is a legitimate value to have. > The notion that you must "always" have a delay is at best misinformed. This change only half fixed the check since there a boot/runtime check at the bottom of the file in sec_scsi_delay. If we're going to allow 0 we should probably also allow values between 0 and 100 as well and just toss the checks. I don't really object to letting the user take aim at their foot if that's what they want to do. -- Brooks --=20 Any statement of the form "X is the one, true Y" is FALSE. PGP fingerprint 655D 519C 26A7 82E7 2529 9BF0 5D8E 8BE9 F238 1AD4 --ZGiS0Q5IWpPtfppv Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.6 (GNU/Linux) Comment: For info see http://www.gnupg.org iD8DBQE9j3huXY6L6fI4GtQRAo2JAKDJhJYzagi5j3j7abNxOavjKVWSGgCeITq/ cxBMc8NC4JNmtSo2BQdbW/c= =0dPH -----END PGP SIGNATURE----- --ZGiS0Q5IWpPtfppv-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-scsi" in the body of the message