From owner-freebsd-stable@FreeBSD.ORG Wed Sep 9 22:13:30 2009 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4C6F41065670; Wed, 9 Sep 2009 22:13:30 +0000 (UTC) (envelope-from vince@unsane.co.uk) Received: from unsane.co.uk (unsane-pt.tunnel.tserv5.lon1.ipv6.he.net [IPv6:2001:470:1f08:110::2]) by mx1.freebsd.org (Postfix) with ESMTP id AD5ED8FC1D; Wed, 9 Sep 2009 22:13:29 +0000 (UTC) Received: from vhoffman-macbook.local ([10.0.0.173]) (authenticated bits=0) by unsane.co.uk (8.14.3/8.14.3) with ESMTP id n89MGeE0029809 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 9 Sep 2009 23:16:41 +0100 (BST) (envelope-from vince@unsane.co.uk) Message-ID: <4AA82888.2080707@unsane.co.uk> Date: Wed, 09 Sep 2009 23:13:28 +0100 From: Vincent Hoffman User-Agent: Thunderbird 2.0.0.23 (Macintosh/20090812) MIME-Version: 1.0 To: Kostik Belousov References: <4AA7D8B3.1010203@unsane.co.uk> <200909091339.00193.jhb@freebsd.org> <20090909190228.GC47688@deviant.kiev.zoral.com.ua> In-Reply-To: <20090909190228.GC47688@deviant.kiev.zoral.com.ua> X-Enigmail-Version: 0.96.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: freebsd-stable@freebsd.org, John Baldwin Subject: Re: general protection fault on boot. X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Sep 2009 22:13:30 -0000 Kostik Belousov wrote: > On Wed, Sep 09, 2009 at 01:38:59PM -0400, John Baldwin wrote: > >> On Wednesday 09 September 2009 12:32:51 pm Vincent Hoffman wrote: >> >>> Hi all, >>> I've been running the 8.0-BETAs in a xen virtual machine >>> (hvm/fully virtualised) for testing and something between r196730 and >>> r196746 causes a general protection fault on boot. I'll try and narrow >>> it down if i get a chance but I'm a a bit busy at the moment. >>> >>> backtrace is available at >>> http://unsane.co.uk/~jhary/freebsd/GPF-09-09-09.gif >>> Xen dom0 is a centos5.3 box using the xen-3.3.1 rpms from >>> http://www.gitco.de/linux/i386/centos/5/rpms/ if thats of any use. >>> >>> Let me know if I need to provide any more info. >>> >> Hmm, can you try reverting 196737? Or actually, can you print out the value >> of %ebx ('p $ebx' in ddb will work I think)? I wonder if this patch would >> fix it: >> >> Index: pmap.c >> =================================================================== >> --- pmap.c (revision 196974) >> +++ pmap.c (working copy) >> @@ -999,7 +999,7 @@ >> * coherence domain. >> */ >> mfence(); >> - for (; sva < eva; sva += cpu_clflush_line_size) >> + for (; sva <= eva; sva += cpu_clflush_line_size) >> clflush(sva); >> mfence(); >> } else { >> > > Oh, no, another pointy hat to me :(. > > Please, try this patch instead. > > diff --git a/sys/i386/xen/pmap.c b/sys/i386/xen/pmap.c > index 4b81aae..122318c 100644 > --- a/sys/i386/xen/pmap.c > +++ b/sys/i386/xen/pmap.c > @@ -1004,8 +1004,8 @@ pmap_invalidate_cache_range(vm_offset_t sva, vm_offset_t eva) > * coherence domain. > */ > mfence(); > - for (; eva < sva; eva += cpu_clflush_line_size) > - clflush(eva); > + for (; sva < eva; sva += cpu_clflush_line_size) > + clflush(sva); > mfence(); > } else { > > Ok will try this tomorrow. Vince