Date: Sun, 20 Oct 2013 11:08:32 +0200 From: =?UTF-8?Q?Ulrich_Sp=C3=B6rlein?= <uqs@FreeBSD.org> To: =?UTF-8?Q?Micka=C3=ABl_Maillot?= <mickael.maillot@gmail.com> Cc: freebsd-ports@freebsd.org Subject: Re: multimedia/xbmc's default dependency on lame Message-ID: <CAJ9axoTvYR_kPJ0aCK1QC74-kMJd9AGk=2yrWQLUogQdtAH2sw@mail.gmail.com> In-Reply-To: <CAKT0JB4FRAGS8QLUEo=ic_0%2B__9_k%2BoLgGFrf7Q8vLQmRVsR5Q@mail.gmail.com> References: <CAJ9axoTcF7SXHmM4iirouG1f40HTWtZ_eYgWorCmzniHo0YgsA@mail.gmail.com> <CAKT0JB4FRAGS8QLUEo=ic_0%2B__9_k%2BoLgGFrf7Q8vLQmRVsR5Q@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--001a11c2e60804420c04e92883d8
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
I'll try and send a patch for this soon.
In the meantime, any idea why this fails on 10.x?
gmake[2]: Entering directory
`/usr/ports/multimedia/xbmc/work/xbmc-12.2/xbmc/cores/dvdplayer/DVDCodecs/V=
ideo'
CPP xbmc/cores/dvdplayer/DVDCodecs/Video/DVDVideoCodecFFmpeg.o
CPP xbmc/cores/dvdplayer/DVDCodecs/Video/DVDVideoCodecLibMpeg2.o
CPP xbmc/cores/dvdplayer/DVDCodecs/Video/DVDVideoPPFFmpeg.o
CPP xbmc/cores/dvdplayer/DVDCodecs/Video/VAAPI.o
VAAPI.cpp:77:10: error: unknown type name 'weak_ptr'
static weak_ptr<CDisplay> display_global;
^
VAAPI.cpp:77:18: error: expected unqualified-id
static weak_ptr<CDisplay> display_global;
^
VAAPI.cpp:79:23: error: use of undeclared identifier 'display_global'
CDisplayPtr display(display_global.lock());
^
VAAPI.cpp:120:3: error: use of undeclared identifier 'display_global'
display_global =3D display;
^
VAAPI.cpp:233:25: warning: cast to 'unsigned char *' from smaller
integer type 'VASurfaceID' (aka 'unsigned int')
[-Wint-to-pointer-cast]
pic->data[3] =3D (uint8_t*)surface;
^
1 warning and 4 errors generated.
I have boost installed and it has the definitions for weak_ptr, so I'm
not sure what's going on here.
gmake(1) tries to compile like this:
root@coyote:/usr/ports/multimedia/xbmc/work/xbmc-12.2/xbmc/cores/dvdplayer/=
DVDCodecs/Video#
gmake -n
rm -f VAAPI.o
echo "CPP xbmc/cores/dvdplayer/DVDCodecs/Video/VAAPI.o"; c++ -MF
VAAPI.d -MD -c -O2 -O2 -pipe -fno-strict-aliasing -fPIC -DPIC
-D_REENTRANT -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=3D64 -DNDEBUG=3D1
-I/usr/local/include -DTARGET_POSIX -DTARGET_FREEBSD -D_LINUX
-D_FILE_DEFINED -D__STDC_CONSTANT_MACROS
-DBIN_INSTALL_PATH=3D"\"/usr/local/lib/xbmc\""
-DINSTALL_PATH=3D"\"/usr/local/share/xbmc\"" -DHAS_SDL_JOYSTICK
-D'GIT_REV=3D"Unknown"' -DHAVE_CONFIG_H
-I/usr/ports/multimedia/xbmc/work/xbmc-12.2/xbmc/cores/dvdplayer
-I/usr/ports/multimedia/xbmc/work/xbmc-12.2/lib
-I/usr/ports/multimedia/xbmc/work/xbmc-12.2/xbmc
-DDBUS_API_SUBJECT_TO_CHANGE -D_GNU_SOURCE=3D1 -D_REENTRANT
-D_THREAD_SAFE -I/usr/local/include -I/usr/local/include/SDL
-I/usr/local/include/dbus-1.0 -I/usr/local/include/dbus-1.0/include
-I/usr/local/include/freetype2 -I/usr/local/include/fribidi
-I/usr/local/include/hal -I/usr/local/include/libcec
-I/usr/local/include/libpng15 -I/usr/local/include/taglib
-I/usr/ports/multimedia/xbmc/work/xbmc-12.2
-I/usr/ports/multimedia/xbmc/work/xbmc-12.2/lib/ffmpeg
-I/usr/ports/multimedia/xbmc/work/xbmc-12.2/xbmc/linux
-I/usr/ports/multimedia/xbmc/work/xbmc-12.2/xbmc/cores/dvdplayer
VAAPI.cpp -o VAAPI.o \
&& cp VAAPI.d VAAPI.P && sed -e 's/#.*//' -e 's/^[^:]*: *//' -e 's/
*\\$//' -e '/^$/ d' -e 's/$/ :/' < VAAPI.d >> VAAPI.P && rm -f VAAPI.d
|| ( rm -f VAAPI.P VAAPI.o && exit 1 )
echo "AR xbmc/cores/dvdplayer/DVDCodecs/Video/Video.a"; ar crus
Video.a DVDVideoCodecFFmpeg.o DVDVideoCodecLibMpeg2.o
DVDVideoPPFFmpeg.o VAAPI.o
...
Oh, then I tried being explicit about that namespace, et voila! It
compiles fine. See attached patch.
But then the pkg-plist somehow doesn't match any longer :(
=3D=3D=3D> Installing for xbmc-12.2_1
=3D=3D=3D> Checking if multimedia/xbmc already installed
=3D=3D=3D> Registering installation for xbmc-12.2_1
pkg-static: lstat(/usr/ports/multimedia/xbmc/work/stage/usr/local/lib/xbmc/=
system/libcmyth-x86_64-freebsd.so):
No such file or directory
*** Error code 74
Sigh. The generated Makefile has
ifeq (0,1)
LIB_DIRS +=3D lib/cmyth
CMYTH=3Dcmyth
endif
so it's unlikely I'll get it built, config.log has nothing about this
and I have no idea what that java thing at the start of the build
tries to do.
Now I only need to figure out why all the unicode conversions are
broken with that new internal iconv support in 10.x :(
Cheers,
Uli
2013/10/19 Micka=C3=ABl Maillot <mickael.maillot@gmail.com>:
> You can remove LAME from default options.
> it's just used for MP3 encoding from CD, not really used by people.
>
>
> 2013/10/18 Ulrich Sp=C3=B6rlein <uqs@freebsd.org>
>>
>> Hey Mickael, Baptiste,
>>
>> multimedia/xbmc is currently broken for me on 10.x (worked fine about
>> 1-2 months ago) and I wanted to check the build cluster to see if the
>> problem is on my end. The problem? multimedia/xbmc is skipped because
>> of the default dependency on lame (and that is restricted).
>>
>> So this
>> http://beefy1.isc.freebsd.org/bulk/head-i386-default/2013-10-17_19h54m49=
s/
>> will not show me if xbmc builds for other people.
>>
>> Mickael, is the default dependency on lame required? It means we'll
>> never ship a pre-built port for it ..
>>
>> Baptiste, is it possible to still build these packages and packages
>> that depend on them, but just not publish/distribute them?
>>
>> Thanks!
>> UIi
>
>
--001a11c2e60804420c04e92883d8--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJ9axoTvYR_kPJ0aCK1QC74-kMJd9AGk=2yrWQLUogQdtAH2sw>