From owner-freebsd-ports-bugs@FreeBSD.ORG  Sun May 15 16:41:06 2005
Return-Path: <owner-freebsd-ports-bugs@FreeBSD.ORG>
Delivered-To: freebsd-ports-bugs@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 15A7116A4D0; Sun, 15 May 2005 16:41:06 +0000 (GMT)
Received: from skynet.stack.nl (skynet.stack.nl [131.155.140.225])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 5573043D96; Sun, 15 May 2005 16:41:05 +0000 (GMT)
	(envelope-from johans@mailhost.gletsjer.net)
Received: by skynet.stack.nl (Postfix, from userid 65534)
	id D0E5E40AD; Sun, 15 May 2005 18:42:00 +0200 (CEST)
Received: from mailhost.gletsjer.net (tunnel03.ipv6.stack.nl
	[IPv6:2001:610:1108:5001::3])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by skynet.stack.nl (Postfix) with ESMTP id 61FA1405A;
	Sun, 15 May 2005 18:42:00 +0200 (CEST)
Received: by mailhost.gletsjer.net (Postfix, from userid 801)
	id B9E154348; Sun, 15 May 2005 18:41:02 +0200 (CEST)
Date: Sun, 15 May 2005 18:41:01 +0200
From: Johan van Selst <johans@stack.nl>
To: Thierry Thomas <thierry@FreeBSD.org>
Message-ID: <20050515164101.GA79599@taz.gletsjer.net>
References: <200505150951.j4F9pmni024169@freefall.freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200505150951.j4F9pmni024169@freefall.freebsd.org>
User-Agent: Mutt/1.5.9i
X-Spam-Level: 
X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on skynet.stack.nl
X-Spam-Status: No, hits=0.0 required=5.0 tests=none autolearn=no version=2.63
cc: freebsd-ports-bugs@FreeBSD.org
Subject: Re: ports/81047: [maintainer] math/gap: update to 4.4.5
X-BeenThere: freebsd-ports-bugs@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Ports bug reports <freebsd-ports-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>,
	<mailto:freebsd-ports-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports-bugs>
List-Post: <mailto:freebsd-ports-bugs@freebsd.org>
List-Help: <mailto:freebsd-ports-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>,
	<mailto:freebsd-ports-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 15 May 2005 16:41:06 -0000

Thierry Thomas wrote:
> Committed, thanks!

Thank you.

> Remarks: it does not respect CFLAGS, and CFLAGS is not copied
> in c_options and c_dyn_options of gac; could you please check
> that?

Good point. Including CFLAGS options during the build can be done by
setting COPTS. Please change the build target to:

do-build:
	(cd ${GAP_WRKSRC}; make COPTS="${CFLAGS}")

Fixing the options in gac is a bit tricky. It should probably use the
CFLAGS that are set when you actually call gac, and not the default
from when the program was installed. This can be done by including the
following patch (as files/patch-gap4r4_cnf_gac.in):

--- gap4r4/cnf/gac.in.orig	Sun May 15 18:26:27 2005
+++ gap4r4/cnf/gac.in	Sun May 15 18:26:23 2005
@@ -67,13 +67,13 @@ stat_identifier="USER";
 
 # These three should be filled in by the standard autoconf procedures 
 c_compiler="@CC@"
-c_options="@CFLAGS@" 
+c_options="@CFLAGS@ ${CFLAGS}" 
 c_linker="@CC@"
-c_link_options=""
+c_link_options="${LDFLAGS}"
 c_libs="@LIBS@"
 
 # These three will need special care 
-c_dyn_options="@CDYNOPTIONS@"
+c_dyn_options="@CDYNOPTIONS@ ${CFLAGS}"
 c_dyn_linker="@CDYNLINKER@"
 c_dyn_linking="@CDYNLINKING@"
 c_dynlibs="@C_DYNLIBS@"