From owner-freebsd-net@FreeBSD.ORG  Fri Mar 23 09:12:47 2012
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: freebsd-net@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 363081065670;
	Fri, 23 Mar 2012 09:12:47 +0000 (UTC)
	(envelope-from monthadar@gmail.com)
Received: from mail-wi0-f172.google.com (mail-wi0-f172.google.com
	[209.85.212.172])
	by mx1.freebsd.org (Postfix) with ESMTP id 6E3178FC0A;
	Fri, 23 Mar 2012 09:12:46 +0000 (UTC)
Received: by wibhj6 with SMTP id hj6so1425699wib.13
	for <multiple recipients>; Fri, 23 Mar 2012 02:12:45 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
	h=mime-version:in-reply-to:references:date:message-id:subject:from:to
	:cc:content-type;
	bh=OJjrxuq+spN0DbkVofINAoM7BtIYvYbO59OPWGOMAcs=;
	b=Xas30E41qzioQQceCCZYAr4KG7IGaXJQFdHe3wcipiKHJtumn/wtaMhmo4C3PdCQHJ
	8bXgZux1Esd4buZbjHsUn/4flB9ljl9bpQxHz5BHIStYwzs4EeqY16MlB4YbAjYNM0b5
	AcD/zDsbb0sRG1SS5FClef5M7cuaRtagyQ0AB66ybjBrtTKw86e9u7NinHSKgI+46P5j
	cQvoVJX9VZzXTN0tq9raso8TTsQFKkzergoFNt0TmTH6Y5SpBN8MevK0H98p4vuLuitn
	G18mWypK5K8qnH5A37UQ5bRTB9WX4DqdUCgKwDrxLguhwf+HxAxmlPbFGBqnZCSppsoa
	ILvw==
MIME-Version: 1.0
Received: by 10.216.133.72 with SMTP id p50mr6713752wei.78.1332493965287; Fri,
	23 Mar 2012 02:12:45 -0700 (PDT)
Received: by 10.223.110.138 with HTTP; Fri, 23 Mar 2012 02:12:45 -0700 (PDT)
In-Reply-To: <CAJ-VmonRmrJ6uQchbY6m=gv8t0jmLkOVbtqqXdV7_frEczOXkQ@mail.gmail.com>
References: <CA+sBSoJaxxRRsUqmpN6k8q6M_SZ_605ip6auN44k5BQ7a_XOtQ@mail.gmail.com>
	<201203221928.16271.bschmidt@freebsd.org>
	<CAJ-VmonJ5w-GpnkXqorqFJ+DcZqoR9kdoPkt9w9A-sXuQccodA@mail.gmail.com>
	<CAJ-VmonRmrJ6uQchbY6m=gv8t0jmLkOVbtqqXdV7_frEczOXkQ@mail.gmail.com>
Date: Fri, 23 Mar 2012 10:12:45 +0100
Message-ID: <CA+sBSoKaZpvXa7o8XCeQwjChDmPfP1Wx3tqi1AzphZW3Bi_wiA@mail.gmail.com>
From: Monthadar Al Jaberi <monthadar@gmail.com>
To: Adrian Chadd <adrian@freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1
Cc: freebsd-net@freebsd.org, Bernhard Schmidt <bschmidt@freebsd.org>
Subject: Re: ifconfig meshforward command bug
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 23 Mar 2012 09:12:47 -0000

On Thu, Mar 22, 2012 at 7:56 PM, Adrian Chadd <adrian@freebsd.org> wrote:
> On 22 March 2012 11:56, Adrian Chadd <adrian@freebsd.org> wrote:
>> On 22 March 2012 11:28, Bernhard Schmidt <bschmidt@freebsd.org> wrote:
>>
>>> Seems about right, those declared with DEF_CMD() should use d.
>>
>> Shall I commit this?
>
> .. a lot of these mesh functions use DECL_CMD_FUNC(), should they all
> be using d?

No I dont think all of them should use d. If you send a value like for
meshttl for example you should not use d, d is only for enable/disable
flags, for example this is CORRECT:

static
DECL_CMD_FUNC(set80211meshttl, val, d)
{
	set80211(s, IEEE80211_IOC_MESH_TTL, atoi(val), 0, NULL);
}

br

>
>
> adrian



-- 
Monthadar Al Jaberi