From owner-svn-ports-all@freebsd.org  Thu Jan  5 16:24:26 2017
Return-Path: <owner-svn-ports-all@freebsd.org>
Delivered-To: svn-ports-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 07931CA0A13;
 Thu,  5 Jan 2017 16:24:26 +0000 (UTC) (envelope-from db@db.net)
Received: from diana.db.net (diana.db.net [66.113.102.10])
 by mx1.freebsd.org (Postfix) with ESMTP id EA6971318;
 Thu,  5 Jan 2017 16:24:25 +0000 (UTC) (envelope-from db@db.net)
Received: from night.db.net (localhost [127.0.0.1])
 by diana.db.net (Postfix) with ESMTP id 338102AA3AD;
 Thu,  5 Jan 2017 09:23:18 -0700 (MST)
Received: by night.db.net (Postfix, from userid 1000)
 id D31F83981A; Thu,  5 Jan 2017 11:24:16 -0500 (EST)
Date: Thu, 5 Jan 2017 11:24:16 -0500
From: Diane Bruce <db@db.net>
To: Jan Beich <jbeich@freebsd.org>
Cc: db@FreeBSD.org, ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
Subject: Re: svn commit: r430641 - in head/comms/wsjtx: . files
Message-ID: <20170105162416.GA49704@night.db.net>
References: <201701051440.v05EeAs3029482@repo.freebsd.org>
 <20170105150259.3BD4A50FB@freefall.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170105150259.3BD4A50FB@freefall.freebsd.org>
User-Agent: Mutt/1.7.2 (2016-11-26)
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 05 Jan 2017 16:24:26 -0000

On Thu, Jan 05, 2017 at 03:02:59PM +0000, Jan Beich wrote:
> Diane Bruce <db@FreeBSD.org> writes:
> 
> > +		libomp.so:devel/openmp
> 
> devel/openmp is currently amd64-only, so comms/wsjtx loses i386 support
> by unconditionally depending on it.

Unfortunate but so marked.

> > +  include_directories("/usr/lib" "${LOCALBASE}/include")
> > +endif()
...
> Why not add USES=localbase:ldflags instead? Besides, -I/usr/lib is bogus
> while -L/usr/lib is poisonous for lang/gcc*.

typo which had no effect upon build anyway. Corrected just because.

> 
> Can you fix svn:mime-type of these files?

psvn went nuts and I had only just noticed and was already fixing when
you sent your email. 

Take care.
-- 
- db@FreeBSD.org db@db.net http://www.db.net/~db