From owner-svn-src-head@FreeBSD.ORG  Mon May 17 18:32:10 2010
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 62999106564A;
	Mon, 17 May 2010 18:32:10 +0000 (UTC)
	(envelope-from matthew.fleming@isilon.com)
Received: from seaxch09.isilon.com (seaxch09.isilon.com [74.85.160.25])
	by mx1.freebsd.org (Postfix) with ESMTP id 3E3B48FC1C;
	Mon, 17 May 2010 18:32:09 +0000 (UTC)
X-MimeOLE: Produced By Microsoft Exchange V6.5
Content-class: urn:content-classes:message
MIME-Version: 1.0
Date: Mon, 17 May 2010 11:28:47 -0700
Message-ID: <06D5F9F6F655AD4C92E28B662F7F853E021D4D6C@seaxch09.desktop.isilon.com>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: svn commit: r208003 - in head/sys: kern sys
Thread-Index: Acr13fOGz6Nv5xS2R+WpPsEqIM73KgAENasM
References: <201005122124.o4CLOk3b027904@svn.freebsd.org>
	<20100516050651.GZ83316@deviant.kiev.zoral.com.ua>
	<06D5F9F6F655AD4C92E28B662F7F853E021D4D66@seaxch09.desktop.isilon.com>
	<20100517162806.GM83316@deviant.kiev.zoral.com.ua>
From: "Matthew Fleming" <matthew.fleming@isilon.com>
To: "Kostik Belousov" <kostikbel@gmail.com>
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
X-Content-Filtered-By: Mailman/MimeDel 2.1.5
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	Zachary Loafman <zml@freebsd.org>, src-committers@freebsd.org
Subject: RE: svn commit: r208003 - in head/sys: kern sys
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 17 May 2010 18:32:10 -0000

From: Kostik Belousov [mailto:kostikbel@gmail.com]

> Essentially, my argument is that whatever you do in VOP_ADVLOCKPURGE,
> can be and should be done in VOP_RECLAIM. This would also cover the =
v_data
> issue.

I disagree about the "should".  I believe that if BSD wants to allow =
overriding lf_advlock(9) with VOP_ADVLOCK it should fully support the =
overriding.  Alternatively, the call to lf_purgelocks(9) should be =
pushed down into each filesystem's VOP_RECLAIM for consistency.

Thanks,
matthew