From owner-svn-src-head@FreeBSD.ORG  Mon Jan  6 05:37:23 2014
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 3146B4E8;
 Mon,  6 Jan 2014 05:37:23 +0000 (UTC)
Received: from mail-qe0-x22f.google.com (mail-qe0-x22f.google.com
 [IPv6:2607:f8b0:400d:c02::22f])
 (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id C054C1725;
 Mon,  6 Jan 2014 05:37:22 +0000 (UTC)
Received: by mail-qe0-f47.google.com with SMTP id t7so17957028qeb.34
 for <multiple recipients>; Sun, 05 Jan 2014 21:37:22 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:sender:in-reply-to:references:date:message-id:subject
 :from:to:cc:content-type;
 bh=nJpgZi/uNgIjSPirQT+yooFYNIzbGwEawTE7ppLinXk=;
 b=F2WgtSVoKUvzAg6mnala7DLXpA4nw7U7IqiGukUs8+awRrFMaXNmUlQ2HpNCVxI2in
 emCM/158FTFB97U/OKfN4f7gk3ITd7o/2SOhYStndKVPQexz7F8Uh+7X2ilpNzE14p4a
 HgzjOvrGQtJTawBW1wfyyX/wRFgwtBllTWPXIJNt6vY7OgytqzJOgoLe9rh/tdtt2MvR
 VeoQswq6TIFujcMRsg5IVZ2z3+6sAHQkShrU0gfdB1aFm7Zlpf4afrlQBBBMjr0lD2D9
 tAdlRTYVdUvkgQpNub+WVIbrq7QAnyBKF/PtxyL2lJWyKe2OCNVXjG2gD7dSX0ovdgRs
 ASrw==
MIME-Version: 1.0
X-Received: by 10.224.124.195 with SMTP id v3mr177167193qar.55.1388986642034; 
 Sun, 05 Jan 2014 21:37:22 -0800 (PST)
Sender: adrian.chadd@gmail.com
Received: by 10.224.52.8 with HTTP; Sun, 5 Jan 2014 21:37:21 -0800 (PST)
In-Reply-To: <20140106035139.GC59496@kib.kiev.ua>
References: <201401060348.s063mW8C031852@svn.freebsd.org>
 <20140106035139.GC59496@kib.kiev.ua>
Date: Sun, 5 Jan 2014 21:37:21 -0800
X-Google-Sender-Auth: 1BgRYk_vEaNwle0fXw1Zzq79tRI
Message-ID: <CAJ-VmomRefeAdd_VdRO8Q8jTpC2hbC7Q22vy_uJB7FX=OUUFLQ@mail.gmail.com>
Subject: Re: svn commit: r260363 - head/sys/dev/ath
From: Adrian Chadd <adrian@freebsd.org>
To: Konstantin Belousov <kostikbel@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Cc: "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>,
 "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>,
 "src-committers@freebsd.org" <src-committers@freebsd.org>
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 06 Jan 2014 05:37:23 -0000

On 5 January 2014 19:51, Konstantin Belousov <kostikbel@gmail.com> wrote:
> On Mon, Jan 06, 2014 at 03:48:32AM +0000, Adrian Chadd wrote:
>> Author: adrian
>> Date: Mon Jan  6 03:48:32 2014
>> New Revision: 260363
>> URL: http://svnweb.freebsd.org/changeset/base/260363
>>
>> Log:
>>   Correctly remove entries from the relevant receive ath_buf list before
>>   freeing them.
>>
>>   The current code would walk the list and call the buffer free, which
>>   didn't remove it from any lists before pushing it back on the free list.
>>
>>   Tested:             AR9485, STA mode
>>
>>   Noticed by: dillon@apollo.dragonflybsd.org
> This is a NOP, right ?

Nope. the previous version didn't remove the entries from the list.
that's the bug.



-a