From owner-freebsd-net@FreeBSD.ORG Thu Jan 17 19:38:07 2013 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id E666E8DB for ; Thu, 17 Jan 2013 19:38:07 +0000 (UTC) (envelope-from stevek@juniper.net) Received: from postoffice.novexsolutions.com (beastie.novexsolutions.com [204.109.60.25]) by mx1.freebsd.org (Postfix) with ESMTP id B4CAAD36 for ; Thu, 17 Jan 2013 19:38:07 +0000 (UTC) X-Authentication-Warning: webmail.novexsolutions.com: www set sender to stevek@juniper.net using -f To: Subject: Re: [JNPR] Proposal for changes to network device drivers and network stack (RFC) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Date: Thu, 17 Jan 2013 14:38:06 -0500 From: "Stephen J. Kiernan" Organization: Juniper Networks, Inc. In-Reply-To: References: Message-ID: X-Sender: stevek@juniper.net User-Agent: Roundcube Webmail/0.7.2 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Jan 2013 19:38:08 -0000 On Jan 17, 2013 14:23, Stephen J. Kiernan wrote: > The network stack as a module patch has been separated out and can be > found in the following location: > http://people.freebsd.org/~marcel/Juniper/netstack-v2.diff > > Details about these changes: I also forgot to mention in the previous e-mail. The patch also includes moving zlib.[ch] and zlibutil.h out of net and into sys/libkern (for the .c) and sys/sys (for the .h). It really doesn't make much sense for that code to live in net, especially when so many things which are not the network stack utilize it. That means that all kernel code that previously included net/zlib.h or net/zlibutil.h now needs to use sys/zlib.h or sys/zlibutil.h, respectively. Is that going to be a problem? Should simple stubs be added in the original locations in net/ to include the one in sys/ now? Note that there were only about a dozen source files in the kernel that needed changing. -- Stephen J. Kiernan Juniper Networks, Inc. stevek_at_juniper.net