From owner-svn-src-head@FreeBSD.ORG Mon Mar 9 15:58:45 2015 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id AD1DA619; Mon, 9 Mar 2015 15:58:45 +0000 (UTC) Received: from pmta2.delivery8.ore.mailhop.org (pmta2.delivery8.ore.mailhop.org [54.148.222.11]) by mx1.freebsd.org (Postfix) with ESMTP id 8B3B5CE1; Mon, 9 Mar 2015 15:58:45 +0000 (UTC) Received: from smtp1.ore.mailhop.org (172.31.18.134) by pmta2.delivery1.ore.mailhop.org id hvn1la216h0j; Mon, 9 Mar 2015 15:59:09 +0000 (envelope-from ) Received: from c-73-34-117-227.hsd1.co.comcast.net ([73.34.117.227] helo=ilsoft.org) by smtp1.ore.mailhop.org with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.82) (envelope-from ) id 1YV04j-0000rK-W2; Mon, 09 Mar 2015 15:58:38 +0000 Received: from revolution.hippie.lan (revolution.hippie.lan [172.22.42.240]) by ilsoft.org (8.14.9/8.14.9) with ESMTP id t29FwaBB007414; Mon, 9 Mar 2015 09:58:36 -0600 (MDT) (envelope-from ian@freebsd.org) X-Mail-Handler: DuoCircle Outbound SMTP X-Originating-IP: 73.34.117.227 X-Report-Abuse-To: abuse@duocircle.com (see https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information for abuse reporting information) X-MHO-User: U2FsdGVkX19nXy9QCMqd969DpJh+Hgn+ Message-ID: <1425916716.73796.28.camel@freebsd.org> Subject: Re: svn commit: r279814 - head/sys/arm/conf From: Ian Lepore To: Warner Losh Date: Mon, 09 Mar 2015 09:58:36 -0600 In-Reply-To: <201503091543.t29FhYVu081001@svn.freebsd.org> References: <201503091543.t29FhYVu081001@svn.freebsd.org> Content-Type: text/plain; charset="us-ascii" X-Mailer: Evolution 3.12.10 FreeBSD GNOME Team Port Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Mar 2015 15:58:45 -0000 On Mon, 2015-03-09 at 15:43 +0000, Warner Losh wrote: > Author: imp > Date: Mon Mar 9 15:43:33 2015 > New Revision: 279814 > URL: https://svnweb.freebsd.org/changeset/base/279814 > > Log: > Add the DTrace modules to the build, rather than only build the dtrace > modules. > > Modified: > head/sys/arm/conf/BEAGLEBONE > > Modified: head/sys/arm/conf/BEAGLEBONE > ============================================================================== > --- head/sys/arm/conf/BEAGLEBONE Mon Mar 9 15:31:33 2015 (r279813) > +++ head/sys/arm/conf/BEAGLEBONE Mon Mar 9 15:43:33 2015 (r279814) > @@ -31,7 +31,7 @@ makeoptions WITHOUT_MODULES="ahc" > options KDTRACE_HOOKS # Kernel DTrace hooks > options DDB_CTF # all architectures - kernel ELF linker loads CTF data > makeoptions WITH_CTF=1 > -makeoptions MODULES_OVERRIDE="opensolaris dtrace dtrace/lockstat dtrace/profile dtrace/fbt" > +makeoptions MODULES_EXTRA="opensolaris dtrace dtrace/lockstat dtrace/profile dtrace/fbt" > > options HZ=100 > options SCHED_4BSD # 4BSD scheduler > > Can we not do this, and instead just build all modules? I'm not sure why we eliminate or override modules on some armv6 socs and not on others, but I think it's a concept that's past it's sell-by date now. If there are a few specific modules that aren't good for arm, we should be fixing that in the modules makefiles. I've got some WIP along these lines for beaglebone that's about ready to commit, so I'm asking your opinion, not for you to do all the work. -- Ian