From nobody Tue Aug 19 14:09:18 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4c5rzy3r1Tz64y1M; Tue, 19 Aug 2025 14:09:18 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4c5rzy3GDqz3YJZ; Tue, 19 Aug 2025 14:09:18 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1755612558; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=gF5N01K9+XhLYo1Mk7PMfSW3/kCR6hx3vHAPb48b1eQ=; b=fJP19OUREFDPPJPazTA8hT/eL4tTvVQQtM14ttJ9mtrUpS7caNjnhRaKVo6YHIkvppOG2+ Hvp15PBz3PH3W9r9tL5pJzllLaqdnHeE6Qa/VJnkn7KEri8jbIe/Oyl+OvQ6Un2U14ahxP JcnnY3Zd8M5uGVUCeUIxDU2mt+Sf+DwaLrAzpBgB6FIfpCz+wR/fQK3K4ksfB/UqziWR1W 5uWR2O2EHGQK6/3+UdL2XkYLlm5Nu3iZ6JiiLatzrDci0mTu0dhwNo5Ni/T+sy8iI0fY6t UK9UArnOHMoCkz8y+cVogw3AnprWy3UB1tTijkM5VzsqFL/1FRzfW9R/gPWQTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1755612558; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=gF5N01K9+XhLYo1Mk7PMfSW3/kCR6hx3vHAPb48b1eQ=; b=xwY21TobBe04vLhQctvPC9C6Sm4ucecpcSxdo0/KPPpgzLuxWZI2rhXSdbikV7AlAXKjvD cuVErfYaZQzC+hRfzWqz7tmMCmTysuSMHev5buZwp0dClGprStjq54CoVOdjW65Mpyfd7B VfKYSbb5KxdVsqb3WAX3DVRrILYJSFedHZPM7cQaQZPYkPic2DUvYfbLz8/U2RTRFC+VM7 9gEg2WsdGqF8yD/FRW5FjNP9aRbM/29IBpKFplsoE50rfXeW2tujM82dBAjbpXM1rAyAVf GK/aUU5uaZEGnTleH6E/aZZPxrji4SsOI0w7oxGrfNwo24+vxY64t017Cwe+GQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1755612558; a=rsa-sha256; cv=none; b=ev5pPusgTUlp7JW4YvpGP9leefDhRzMgIvx57/SjBQgyaCkVeY8E3nM0k48eaam+LGFE9y Dt/GI+VGbSVtNP7NKgtnOnr+72P3yXMID5P8ia8516+goOE6+P8nTuA1W/g+EJvNObHElL J9HOSGh4sOSWYWkSSoiyZvSzlthMVNSj/joLNjRVgglw7elfjtbZwLJt7WcZUGQYbK2rOJ /f689gKJlqqWXnTg11suA5/XH3iE5I65emwg8hbuZDacjajWSxDpLb4tZ1NRzsKkSOhCne EmS5kjNUz0T4SGTfRf81O04/z2ypHWIy43XsG/GJWPWOugtnyOZoHZfEz6xpDQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4c5rzy2qjVzVV7; Tue, 19 Aug 2025 14:09:18 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 57JE9ITu021799; Tue, 19 Aug 2025 14:09:18 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 57JE9Ild021796; Tue, 19 Aug 2025 14:09:18 GMT (envelope-from git) Date: Tue, 19 Aug 2025 14:09:18 GMT Message-Id: <202508191409.57JE9Ild021796@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Mark Johnston Subject: git: 3d4d778262e4 - main - random: Correct wording in a comment List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 3d4d778262e459c9c80781a3474908d090ffb061 Auto-Submitted: auto-generated The branch main has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=3d4d778262e459c9c80781a3474908d090ffb061 commit 3d4d778262e459c9c80781a3474908d090ffb061 Author: Mark Johnston AuthorDate: 2025-08-19 14:04:57 +0000 Commit: Mark Johnston CommitDate: 2025-08-19 14:04:57 +0000 random: Correct wording in a comment In the calculation of the cutoff value, we haven't changed the window size itself, just the example formula, which takes the window size as a parameter. Reviewed by: cem Fixes: f92ff79720fb ("random: Add NIST SP 800-90B entropy source health test implementations") Sponsored by: Stormshield Sponsored by: Klara, Inc. Differential Revision: https://reviews.freebsd.org/D52002 --- sys/dev/random/random_harvestq.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/sys/dev/random/random_harvestq.c b/sys/dev/random/random_harvestq.c index c7762967c4fb..ced15262457f 100644 --- a/sys/dev/random/random_harvestq.c +++ b/sys/dev/random/random_harvestq.c @@ -493,9 +493,9 @@ random_healthtest_init(enum random_entropy_source source) * The RCT limit comes from the formula in section 4.4.1. * * The APT cutoff is calculated using the formula in section 4.4.2 - * footnote 10 with the window size changed from 512 to 511, since the - * test as written counts the number of samples equal to the first - * sample in the window, and thus tests W-1 samples. + * footnote 10 with the number of Bernoulli trials changed from W to + * W-1, since the test as written counts the number of samples equal to + * the first sample in the window, and thus tests W-1 samples. */ ht->ht_rct_limit = 35; ht->ht_apt_cutoff = 330;