Date: Mon, 19 Jul 2004 13:22:41 -0400 From: Garance A Drosihn <drosih@rpi.edu> To: John Baldwin <jhb@FreeBSD.org>, Brian Fundakowski Feldman <green@FreeBSD.org> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/sys malloc.h src/sys/kern kern_malloc.c src/sys/vm vm_contig.c vm_page.h Message-ID: <p06110418bd21b3324863@[128.113.24.47]> In-Reply-To: <200407190925.56489.jhb@FreeBSD.org> References: <200407190621.i6J6LRWJ019976@repoman.freebsd.org> <20040719071147.GS18577@cs.rice.edu> <20040719103917.GD1038@green.homeunix.org> <200407190925.56489.jhb@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
At 9:25 AM -0400 7/19/04, John Baldwin wrote: >On Monday 19 July 2004 06:39 am, Brian Fundakowski Feldman wrote: > > > > Aye, I didn't feel totally comfortable saying "Reviewed by:" since > > that was a while ago, ... > >For future reference: In this case I usually add a line along the >lines of: > >Reviewed by: bde (an earlier version) > >Which is both truthful and avoids the ensuing flamewar due to >the appearance of an unreviewed driveby. :) This sounds like a good method to follow. Another thing to say is "by silence on freebsd-blah", so that you document that others had a chance to review it, but no one picked up on the opportunity. -- Garance Alistair Drosehn = gad@gilead.netel.rpi.edu Senior Systems Programmer or gad@freebsd.org Rensselaer Polytechnic Institute or drosih@rpi.edu
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?p06110418bd21b3324863>