From owner-freebsd-stable@FreeBSD.ORG  Fri Apr 13 07:23:56 2007
Return-Path: <owner-freebsd-stable@FreeBSD.ORG>
X-Original-To: stable@freebsd.org
Delivered-To: freebsd-stable@FreeBSD.ORG
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id B508916A402
	for <stable@freebsd.org>; Fri, 13 Apr 2007 07:23:56 +0000 (UTC)
	(envelope-from Hartmut.Brandt@dlr.de)
Received: from smtp-2.dlr.de (smtp-3.dlr.de [195.37.61.187])
	by mx1.freebsd.org (Postfix) with ESMTP id 5360413C468
	for <stable@freebsd.org>; Fri, 13 Apr 2007 07:23:56 +0000 (UTC)
	(envelope-from Hartmut.Brandt@dlr.de)
Received: from exbe04.intra.dlr.de ([192.168.35.37]) by smtp-2.dlr.de with
	Microsoft SMTPSVC(6.0.3790.1830); Fri, 13 Apr 2007 09:11:50 +0200
X-MimeOLE: Produced By Microsoft Exchange V6.5
Content-class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Date: Fri, 13 Apr 2007 09:10:42 +0200
Message-ID: <B38B5A899DA36E439EC6278C1C307B51015D0202@exbe04.intra.dlr.de>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: make: parallel jobs broken when using -f -
Thread-Index: Acd9gimCrwiJXNehR8WUlkuWxvGnPgAGK9iD
References: <20070412212404.GA1597@roadrunner.q.local>
	<20070413040819.GA39290@rambler-co.ru>
From: <Hartmut.Brandt@dlr.de>
To: <ru@freebsd.org>,
	<harti@freebsd.org>,
	<stable@freebsd.org>
X-OriginalArrivalTime: 13 Apr 2007 07:11:50.0109 (UTC)
	FILETIME=[017360D0:01C77D9B]
Cc: 
Subject: RE: make: parallel jobs broken when using -f -
X-BeenThere: freebsd-stable@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Production branch of FreeBSD source code <freebsd-stable.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-stable>, 
	<mailto:freebsd-stable-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-stable>
List-Post: <mailto:freebsd-stable@freebsd.org>
List-Help: <mailto:freebsd-stable-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-stable>,
	<mailto:freebsd-stable-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 13 Apr 2007 07:23:56 -0000

Thanks Ruslan for taking care. I'm currently in Seoul on a conference - =
no time :-)
=20
harti

________________________________

From: Ruslan Ermilov [mailto:ru@freebsd.org]
Sent: Fri 4/13/2007 6:08 AM
To: harti@freebsd.org; stable@freebsd.org
Subject: Re: make: parallel jobs broken when using -f -



Hi Ulrich,

On Thu, Apr 12, 2007 at 11:24:04PM +0200, Ulrich Spoerlein wrote:
> there is an annoying bug in 6-STABLE make(1), where -f - seems to
> serialize the target making.
>
> Consider the following Makefile
>
> all: a b c d
>
> a b c d:
>         @echo Makeing ${.TARGET}
>         @sleep 4
>
> And observe the following behaviour:
> $ make -j4
> Makeing a
> Makeing b
> Makeing c
> Makeing d
>   <pause>
> $ make -j4 -f- < Makefile
> Makeing b
> Makeing d
>   <pause>
> Makeing a
>   <pause>
> Makeing c
>   <pause>
> $
>
> The make(1) on -CURRENT has this fixed already, is there any chance of
> this getting MFCed?
>
> AFAICS the following revisions are not up to date (wrt to CURRENT):
>      $FreeBSD: src/usr.bin/make/job.c,v 1.122.2.1 2005/07/20 19:05:23 =
harti Exp $
>      $FreeBSD: src/usr.bin/make/main.c,v 1.155 2005/05/24 16:05:51 =
harti Exp $
>      $FreeBSD: src/usr.bin/make/parse.c,v 1.108.2.1 2005/11/16 =
08:25:19 ru Exp $
>      $FreeBSD: src/usr.bin/make/str.c,v 1.45.2.1 2006/10/16 11:51:18 =
ru Exp $
>      $FreeBSD: src/usr.bin/make/var.c,v 1.159 2005/05/24 16:05:51 =
harti Exp $
>
The bug you're seeing is PR bin/101232.  Please query
Will Andrews about the MFC, or if he doesn't reply in
a timely manner, ping me and I'll commit it for you.


Cheers,
--
Ruslan Ermilov
ru@FreeBSD.org
FreeBSD committer