From owner-svn-src-all@FreeBSD.ORG Mon Feb 14 18:47:19 2011 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D605D1065694; Mon, 14 Feb 2011 18:47:19 +0000 (UTC) (envelope-from mdf356@gmail.com) Received: from mail-ww0-f42.google.com (mail-ww0-f42.google.com [74.125.82.42]) by mx1.freebsd.org (Postfix) with ESMTP id ADBD88FC1B; Mon, 14 Feb 2011 18:47:18 +0000 (UTC) Received: by wwi17 with SMTP id 17so2210722wwi.1 for ; Mon, 14 Feb 2011 10:47:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=PrZ27HjedUIsliEKOcaOdcK5+x6Ivwf9glvc8RSjABM=; b=H/yeiWXgbk76PFrqLcHC76XPAlzW+jdUqnYKnfBVkN2F2pSSmEoCMAwdqSCpqicja5 bcVdDUjgwLZGdaH5D6z53b8N8oO+qNLqc+jyK2xWSXrozLbsN0igt2KvCgM9d54Gj+OZ ZtkM9fliS2+ZCHjausH/Oj+usYTC+KM25nur8= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=gpX6a7vMz540ot4TShsie5I1iG9aq/LfoJ8UWBjHemWgNciTyHXl+O2rfgHisfv9kP JW6myKwLrDFC4RljEBLF1mOLusJ3JL1vOh6F9Icpo+OvnDlAHU4x45dZ2sSdMxG3uBnc hYFFvykNu4r+8uytpQzw3d7R5D1DTYBUbdeSw= MIME-Version: 1.0 Received: by 10.216.162.131 with SMTP id y3mr3611237wek.6.1297709237214; Mon, 14 Feb 2011 10:47:17 -0800 (PST) Sender: mdf356@gmail.com Received: by 10.216.86.200 with HTTP; Mon, 14 Feb 2011 10:47:17 -0800 (PST) In-Reply-To: <201102141333.05054.jhb@freebsd.org> References: <201102141720.p1EHKKeU000451@svn.freebsd.org> <201102141333.05054.jhb@freebsd.org> Date: Mon, 14 Feb 2011 10:47:17 -0800 X-Google-Sender-Auth: 5bFHl5MOFjpMyQLsCJ40QVJ7xpM Message-ID: From: mdf@FreeBSD.org To: John Baldwin Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r218685 - head/sys/dev/acpica X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Feb 2011 18:47:20 -0000 On Mon, Feb 14, 2011 at 10:33 AM, John Baldwin wrote: > On Monday, February 14, 2011 12:20:20 pm Matthew D Fleming wrote: >> Author: mdf >> Date: Mon Feb 14 17:20:20 2011 >> New Revision: 218685 >> URL: http://svn.freebsd.org/changeset/base/218685 >> >> Log: >> =A0 Prevent reading from the ACPI_RESOURCE past its actual end. =A0For >> =A0 paranoia limit to the size of the ACPI_RESOURCE as well. > > I think in practice that len would never be > sizeof(ACPI_RESOURCE). > > You could probably get by with using a KASSERT() instead: > > =A0 =A0 =A0 =A0KASSERT(res->Length <=3D sizeof(ACPI_RESOURCE), "resource = too large")); > =A0 =A0 =A0 =A0bcopy(res, req->acpi_res, res->Length); Thanks. I wanted to be paranoid since the problem was sporadic. Anyone who can better test this code should feel free to modify it further. Thanks, matthew