From owner-svn-src-head@FreeBSD.ORG  Mon Aug  4 09:24:04 2014
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id B842793E;
 Mon,  4 Aug 2014 09:24:04 +0000 (UTC)
Received: from mail110.syd.optusnet.com.au (mail110.syd.optusnet.com.au
 [211.29.132.97])
 by mx1.freebsd.org (Postfix) with ESMTP id 795652BA7;
 Mon,  4 Aug 2014 09:24:04 +0000 (UTC)
Received: from c122-106-147-133.carlnfd1.nsw.optusnet.com.au
 (c122-106-147-133.carlnfd1.nsw.optusnet.com.au [122.106.147.133])
 by mail110.syd.optusnet.com.au (Postfix) with ESMTPS id 068A478D955;
 Mon,  4 Aug 2014 19:23:55 +1000 (EST)
Date: Mon, 4 Aug 2014 19:23:52 +1000 (EST)
From: Bruce Evans <brde@optusnet.com.au>
X-X-Sender: bde@besplex.bde.org
To: Garrett Cooper <ngie@freebsd.org>
Subject: Re: svn commit: r269505 - head/libexec/rtld-elf/tests/target
In-Reply-To: <53df1ed9.5830.34b38bca@svn.freebsd.org>
Message-ID: <20140804185707.P7764@besplex.bde.org>
References: <53df1ed9.5830.34b38bca@svn.freebsd.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
X-Optus-CM-Score: 0
X-Optus-CM-Analysis: v=2.1 cv=B4eAjodM c=1 sm=1 tr=0
 a=7NqvjVvQucbO2RlWB8PEog==:117 a=PO7r1zJSAAAA:8 a=tydDgHasiwwA:10
 a=6LNvDgAQAgwA:10 a=kj9zAlcOel0A:10 a=JzwRw_2MAAAA:8
 a=STB_ahwqhOoAzwSsIzAA:9 a=CjuIK1q_8ugA:10
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
 src-committers@freebsd.org
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 04 Aug 2014 09:24:04 -0000

On Mon, 4 Aug 2014, Garrett Cooper wrote:

> Log:
>  Move a -L argument from LDADD to LDFLAGS
>
>  Phabric: D525 (part of a larger patch)
>
>  Reviewed by: jmmv
>  Approved by: jmmv (co-mentor)
>
> Modified:
>  head/libexec/rtld-elf/tests/target/Makefile
>
> Modified: head/libexec/rtld-elf/tests/target/Makefile
> ==============================================================================
> --- head/libexec/rtld-elf/tests/target/Makefile	Mon Aug  4 05:46:10 2014	(r269504)
> +++ head/libexec/rtld-elf/tests/target/Makefile	Mon Aug  4 05:49:13 2014	(r269505)
> @@ -6,7 +6,9 @@ PROG=		target
> BINDIR=		${TESTSBASE}${TESTSDIR}/libexec/rtld-elf
>
> CFLAGS+=	-I${.CURDIR}/../libpythagoras
> -LDADD=		-L${.OBJDIR}/../libpythagoras -lpythagoras
> +
> +LDFLAGS+=	-L${.OBJDIR}/../libpythagoras
> +LDADD=		-lpythagoras
>
> MAN=

I hope this fixes the error found by "make checkdpadd".  -L is too hard
for the current "make checkdpadd" to handle.  Old aout versions worked
better using linker support.  They also found the correct dependencies
(on shared libraries for shared linkage, not the pseudo-dependenci on
the hard-coded static librar for shared linkage).

"make checkdpadd" currently finds broken 143 makefiles with inconsistent
DPADD.  62 of them are for clang.  Most of these misuse DPADD for
headers.  The next largest source of errors is libtermcapw.  LIBTERMCAPW
is missing in bsd.libnames.mk.  This breaks about 29 makefiles where
LIBTERMCAP was blindly replaced by LIBTERMCAPW.  bsd.libnames.mk and
DPADD were unnecessary with the old aout versions.

Bruce