From owner-svn-src-head@freebsd.org Tue Sep 3 14:06:25 2019 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 89299DC739; Tue, 3 Sep 2019 14:06:19 +0000 (UTC) (envelope-from yuripv@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46N7zF5NJCz4PP1; Tue, 3 Sep 2019 14:06:17 +0000 (UTC) (envelope-from yuripv@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 1452) id 3C6781A432; Tue, 3 Sep 2019 14:06:04 +0000 (UTC) X-Original-To: yuripv@localmail.freebsd.org Delivered-To: yuripv@localmail.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client CN "mx1.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by freefall.freebsd.org (Postfix) with ESMTPS id 6C00C121ED; Fri, 5 Apr 2019 19:51:52 +0000 (UTC) (envelope-from owner-src-committers@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 1D25971FA8; Fri, 5 Apr 2019 19:51:52 +0000 (UTC) (envelope-from owner-src-committers@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 538) id 0D43B121EC; Fri, 5 Apr 2019 19:51:52 +0000 (UTC) Delivered-To: src-committers@localmail.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client CN "mx1.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by freefall.freebsd.org (Postfix) with ESMTPS id B4B72121E8; Fri, 5 Apr 2019 19:51:49 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: from mail-it1-f175.google.com (mail-it1-f175.google.com [209.85.166.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 7AFCC71F9D; Fri, 5 Apr 2019 19:51:49 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: by mail-it1-f175.google.com with SMTP id x132so1093427itf.2; Fri, 05 Apr 2019 12:51:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:reply-to :from:date:message-id:subject:to:cc; bh=RbNG3ImuDjC4qrdzfYb6IZAnAmiiuDVLXHVgyjulW8Y=; b=BB/JkuAsps4rBT1aogZb9rRncvsdMas5XW9knhhoC/kSMPniI/xN/IeOSIJbeLM+XZ Txbt1SVKYWekE12jcSUmT2NXAdhYlA4PPyy1eyN69c7k6GrxJwNNA4P7TFNHTJcztMBM 5hx/O0TjWthtU5iRP/kblNAx1p9b1dFGVFAOtbGPK4MKEw0LAqVJDTwnXPfMaOl2UhSB GS/w7RZOEHsehJ3T5NgNBxnHxUWn6No4u9mSHSfrPg+igP2I/KZ5ois+SJCTUMYW1kjE DVznM0nsKmkeGvwBezJ7cH+lB9f1hTuFDdtU2gaodkD7Rer3qPFlcFaZVBF4E2Gkh7E5 Qz0A== X-Gm-Message-State: APjAAAWNry3rYnl0ObXMzFJtm5Kew1vEmRefFZPbbdMBDbBY9wAegawd FpR7S8xjDAFzOA+Ng94zJX6ZIQXp X-Google-Smtp-Source: APXvYqwsFp84r5A3uPLT+2ucCI+qW186x6KEyqX66yrftxpvG4ombZMqEn5D9yLx0UXnkYHDUZY7Og== X-Received: by 2002:a02:76cc:: with SMTP id z195mr11435093jab.127.1554493907933; Fri, 05 Apr 2019 12:51:47 -0700 (PDT) Received: from mail-it1-f173.google.com (mail-it1-f173.google.com. [209.85.166.173]) by smtp.gmail.com with ESMTPSA id m143sm1482070itm.32.2019.04.05.12.51.47 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 05 Apr 2019 12:51:47 -0700 (PDT) Received: by mail-it1-f173.google.com with SMTP id a190so11391240ite.4; Fri, 05 Apr 2019 12:51:47 -0700 (PDT) X-Received: by 2002:a02:62ce:: with SMTP id d197mr11479960jac.91.1554493907413; Fri, 05 Apr 2019 12:51:47 -0700 (PDT) MIME-Version: 1.0 References: <201904050221.x352LGjU015040@repo.freebsd.org> <201904050449.x354nUEC036896@gndrsh.dnsmgr.net> In-Reply-To: Reply-To: cem@freebsd.org From: Conrad Meyer X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r345900 - head/sbin/fsck_msdosfs To: Ed Maste Cc: Xin LI , src-committers , svn-src-all , svn-src-head Content-Type: text/plain; charset="UTF-8" Precedence: bulk X-Loop: FreeBSD.org Sender: owner-src-committers@freebsd.org X-Rspamd-Queue-Id: 1D25971FA8 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.97 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.97)[-0.968,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] Status: O X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Date: Tue, 03 Sep 2019 14:06:26 -0000 X-Original-Date: Fri, 5 Apr 2019 12:51:36 -0700 X-List-Received-Date: Tue, 03 Sep 2019 14:06:26 -0000 On Fri, Apr 5, 2019 at 6:49 AM Ed Maste wrote: > > On Fri, 5 Apr 2019 at 00:49, Rodney W. Grimes wrote: > > > > > > +static const u_char dot_name[] = { > > > + '.', ' ',' ',' ',' ',' ',' ',' ',' ',' ',' ' }; > > > +static const u_char dotdot_name[] = { > > > + '.', '.',' ',' ',' ',' ',' ',' ',' ',' ',' ' }; > > > + > > They are all either '.' or ' ', the commas are just list separators. > IMO spaces after the commas would make it slightly easier to see. Would it make sense to just use the normal string syntax for char array assignment? static const u_char dot_name[11] = ". "; static const u_char dotdot_name[11] = ".. "; Seems more clear to me. Best, Conrad