From owner-svn-ports-head@FreeBSD.ORG  Fri Mar 27 01:41:29 2015
Return-Path: <owner-svn-ports-head@FreeBSD.ORG>
Delivered-To: svn-ports-head@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 1033)
 id 6A233AC3; Fri, 27 Mar 2015 01:41:29 +0000 (UTC)
Date: Fri, 27 Mar 2015 01:41:29 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Adam Weinberger <adamw@FreeBSD.org>
Subject: Re: svn commit: r382355 - head/graphics/entangle
Message-ID: <20150327014129.GA35030@FreeBSD.org>
References: <201503262330.t2QNUq3H058554@svn.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201503262330.t2QNUq3H058554@svn.freebsd.org>
User-Agent: Mutt/1.5.23 (2014-03-12)
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 27 Mar 2015 01:41:29 -0000

On Thu, Mar 26, 2015 at 11:30:52PM +0000, Adam Weinberger wrote:
> New Revision: 382355
> URL: https://svnweb.freebsd.org/changeset/ports/382355
> QAT: https://qat.redports.org/buildarchive/r382355/
> 
> Log:
>   Update graphics/entangle to 0.7.0, and assign maintainership to
>   submitter (Ben Woods).

Nice, I've been waiting for a while to someone to grab this from me.  Having
to install gtk3 everytime I was working on an update was a PITA.

> -BUILD_DEPENDS=	${LOCALBASE}/share/icons/mate/scalable/devices/camera-photo-symbolic.svg:${PORTSDIR}/x11-themes/mate-icon-theme
> +BUILD_DEPENDS=	${LOCALBASE}/share/icons/mate/scalable/devices/camera-photo-symbolic.svg:${PORTSDIR}/x11-themes/mate-icon-theme \
> +		itstool:${PORTSDIR}/textproc/itstool
>  LIB_DEPENDS=	libgphoto2.so:${PORTSDIR}/graphics/libgphoto2 \
>  		libdbus-glib-1.so:${PORTSDIR}/devel/dbus-glib \
>  		liblcms2.so:${PORTSDIR}/graphics/lcms2 \
> @@ -20,10 +21,13 @@ LIB_DEPENDS=	libgphoto2.so:${PORTSDIR}/g
>  		libpeas-1.0.so:${PORTSDIR}/devel/libpeas
>  RUN_DEPENDS:=	${BUILD_DEPENDS}

Isn't itstool(1) a build-time only tool?  If so, it means that BUILD_DEPENDS
is no longer equal to RUN_DEPENDS, so I think they have to be set explicitly
now.  Alternatively, you can first set RUN_DEPENDS (mate-icon-theme), then
assign BUILD_DEPENDS:= ${RUN_DEPENDS} itstool:${PORTSDIR}/textproc/itstool,
but it's kind of in bogus order, we probably should not encourage this.

./danfe