From owner-p4-projects@FreeBSD.ORG  Thu Dec 23 19:20:57 2004
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id B4E5716A4D0; Thu, 23 Dec 2004 19:20:56 +0000 (GMT)
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 878AB16A4CE
	for <perforce@freebsd.org>; Thu, 23 Dec 2004 19:20:56 +0000 (GMT)
Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 6150D43D2D
	for <perforce@freebsd.org>; Thu, 23 Dec 2004 19:20:56 +0000 (GMT)
	(envelope-from jhb@freebsd.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id iBNJKuqg074650
	for <perforce@freebsd.org>; Thu, 23 Dec 2004 19:20:56 GMT
	(envelope-from jhb@freebsd.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.13.1/8.13.1/Submit) id iBNJKu7B074647
	for perforce@freebsd.org; Thu, 23 Dec 2004 19:20:56 GMT
	(envelope-from jhb@freebsd.org)
Date: Thu, 23 Dec 2004 19:20:56 GMT
Message-Id: <200412231920.iBNJKu7B074647@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	jhb@freebsd.org using -f
From: John Baldwin <jhb@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Subject: PERFORCE change 67595 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 23 Dec 2004 19:20:57 -0000

http://perforce.freebsd.org/chv.cgi?CH=67595

Change 67595 by jhb@jhb_slimer on 2004/12/23 19:20:04

	Defer tty_close() until the very end of ttyclose() since tty_close()
	may remove the last reference to 'tp' via ttyrel() resulting in it
	being free'd.

Affected files ...

.. //depot/projects/smpng/sys/kern/tty.c#54 edit

Differences ...

==== //depot/projects/smpng/sys/kern/tty.c#54 (text+ko) ====

@@ -3172,10 +3172,10 @@
 	ttyldoptim(tp);
 	if (tp->t_close != NULL)
 		tp->t_close(tp);
-	tty_close(tp);
 	tp->t_do_timestamp = 0;
 	if (tp->t_pps != NULL)
 		tp->t_pps->ppsparam.mode = 0;
+	tty_close(tp);
 	return (0);
 }