From nobody Fri Feb 6 17:59:26 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4f720Z2X5Cz6FNYT for ; Fri, 06 Feb 2026 17:59:26 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4f720Z1h2Rz4KDv for ; Fri, 06 Feb 2026 17:59:26 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1770400766; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=IZVbumBwGqhU/5pO2+iQbV+dE+qTrZ339BVyIAWRkoI=; b=SZTCScAWqeAEDDQHnaDC7DpcLUzN4ks0buxwcNRXNAdqqTTTIzhaZl6zD2BCCApMqtG0rO buVUqZSxl+f6LYmXmo92Ao05Tk6tl0jlifKIwdycFwOQSqtZWiqNDVg/ztqegr4zIM121y TGvbDcuKfeVUf0FuZPDSV4OZpExgt09j8MDGKJnzpFzqg3cFYCVThlUS31Yeuw0PQr9Urp TzDwMCGNkme866EYrZxG0486zwyg8Iucc04ldcoueviXlrm/bNpxdu2sOGIHUF3VXojmwg VwSw+YDvvU5aZl7sH/phN//0qqTNQvQl2RrkIiwWcls8+0lSZPdY05Kl0EUU3A== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1770400766; a=rsa-sha256; cv=none; b=p+vkbg0rdQha3BUQ8/ulAQmlrAinDvI1tzSei0wuJ2DBEpm47vYNF63H6yAC+xlPM0t0hA NAf1hlz75D0nbp1bLXGmQSl8ZKc+04xYV6HHtwWwvbjHms5zoLl+RleHegYBkT6HiD28ng 3THxAkII86vt+8/+LqbQ5IFw0OpoaEO7OtAxrgiK7AhL0SPQFet9uVn90x9420ZLU+ymDr pa/WdQ6x6GxJAYsThMA9OoVrjZcE4ziYSx8HOO7KzIe7LKt9RELfc49Asu8juAPw9+lFG7 TdFe0tmE5k1170dVM/tWMD/p/SF2ayqi+BMl5x0KPFtxQ41zsaMNE46hzI593g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1770400766; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=IZVbumBwGqhU/5pO2+iQbV+dE+qTrZ339BVyIAWRkoI=; b=nL6QhAgoSn51hoYrQkgY75cy5DZv5sDkqmRPzp8yliadGW6K+mlJw3ZuhEsAMpBUttF8Ni 1+ju7exEAlBNvJG/8A0SlMuvoSFmgVK3Okn1PNcgF+6GBunEX71gmDM8+lE28v2QWOAGm9 YL/WXCtaLOwSctS7HSUXQtfiPCCwafvvynWbZbzH/hqu9ARsp5qVhvpMcHQB+DJvMHOrQa z/R9lNpE1kbmJuw8/24340uWz7CRzNuRAmkHky0xTEWlRvXaWgHqAFbCswagS0nyk7pvPK /eH2Zqd9aSs8ej6vi3K+yAQiZiXUZV5ppYTbAaSsC3oWg2m+u1nV2gqym5rTEA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4f720Z14PVz9j9 for ; Fri, 06 Feb 2026 17:59:26 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 271b3 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 06 Feb 2026 17:59:26 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Zhenlei Huang Subject: git: 4ac3081b2828 - main - qlnxe: Remove a pointless copy back from the link-layer address List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: zlei X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 4ac3081b282800158df7abe93f307d76e1b5b808 Auto-Submitted: auto-generated Date: Fri, 06 Feb 2026 17:59:26 +0000 Message-Id: <69862bfe.271b3.1ec742ec@gitrepo.freebsd.org> The branch main has been updated by zlei: URL: https://cgit.FreeBSD.org/src/commit/?id=4ac3081b282800158df7abe93f307d76e1b5b808 commit 4ac3081b282800158df7abe93f307d76e1b5b808 Author: Zhenlei Huang AuthorDate: 2026-02-06 17:52:53 +0000 Commit: Zhenlei Huang CommitDate: 2026-02-06 17:52:53 +0000 qlnxe: Remove a pointless copy back from the link-layer address On ifnet attaching, ether_ifattach() makes the link-layer address by shadow copying the ha->primary_mac. Well, the link-layer address will not be altered during attaching, thus it is pointless to copy it back. No functional change intended. Reviewed by: kbowling MFC after: 5 days Differential Revision: https://reviews.freebsd.org/D54883 --- sys/dev/qlnx/qlnxe/qlnx_os.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/sys/dev/qlnx/qlnxe/qlnx_os.c b/sys/dev/qlnx/qlnxe/qlnx_os.c index 99110e5e2d8f..9616d9f4d611 100644 --- a/sys/dev/qlnx/qlnxe/qlnx_os.c +++ b/sys/dev/qlnx/qlnxe/qlnx_os.c @@ -2392,8 +2392,6 @@ qlnx_init_ifnet(device_t dev, qlnx_host_t *ha) ifmedia_set(&ha->media, (IFM_ETHER | IFM_AUTO)); ether_ifattach(ifp, ha->primary_mac); - bcopy(if_getlladdr(ha->ifp), ha->primary_mac, ETHER_ADDR_LEN); - QL_DPRINT2(ha, "exit\n"); return;