From owner-freebsd-ports@FreeBSD.ORG  Sun Aug  5 21:13:49 2007
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
Delivered-To: ports@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 6F06316A418;
	Sun,  5 Aug 2007 21:13:49 +0000 (UTC)
	(envelope-from kris@obsecurity.org)
Received: from elvis.mu.org (elvis.mu.org [192.203.228.196])
	by mx1.freebsd.org (Postfix) with ESMTP id 607C113C45D;
	Sun,  5 Aug 2007 21:13:49 +0000 (UTC)
	(envelope-from kris@obsecurity.org)
Received: from rot26.obsecurity.org (elvis.mu.org [192.203.228.196])
	by elvis.mu.org (Postfix) with ESMTP id 3E6481A4D7C;
	Sun,  5 Aug 2007 14:13:04 -0700 (PDT)
Received: by rot26.obsecurity.org (Postfix, from userid 1001)
	id A47DDC1D2; Sun,  5 Aug 2007 17:13:48 -0400 (EDT)
Date: Sun, 5 Aug 2007 17:13:48 -0400
From: Kris Kennaway <kris@obsecurity.org>
To: Gabor Kovesdan <gabor@FreeBSD.org>
Message-ID: <20070805211348.GA24361@rot26.obsecurity.org>
References: <20070805055340.GA11899@rot26.obsecurity.org>
	<46B637AA.1040001@FreeBSD.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <46B637AA.1040001@FreeBSD.org>
User-Agent: Mutt/1.4.2.3i
Cc: ports@FreeBSD.org, Kris Kennaway <kris@obsecurity.org>
Subject: Re: PORTSDIR use-before-define fix
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 05 Aug 2007 21:13:49 -0000

On Sun, Aug 05, 2007 at 10:48:42PM +0200, Gabor Kovesdan wrote:
> Kris Kennaway escribi?:
> >Previous DESTDIR commits introduced dereferences of ${PORTSDIR} before
> >it was set (via .include), which broke e.g. portmaster.  This diff
> >shuffles some things around to hopefully restore everything to being
> >defined before it is used.  It also cleans up some stale cruft.  It
> >has only been lightly tested.
> >
> >  
> I haven't tested it yet, but it seems good to me. Thanks for working on 
> this! I'll test it a bit next
> day. What about COMMENTFILE? I see it was removed, but can't see it 
> added back. Is it
> completely obsolete?

Yes, for 3 years now :)

Kris