From owner-freebsd-stable@freebsd.org  Wed Aug 24 05:41:12 2016
Return-Path: <owner-freebsd-stable@freebsd.org>
Delivered-To: freebsd-stable@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 21CCDBC3EB8
 for <freebsd-stable@mailman.ysv.freebsd.org>;
 Wed, 24 Aug 2016 05:41:12 +0000 (UTC)
 (envelope-from andreas@naund.org)
Received: from naund.org (172-11-194-172.lightspeed.sntcca.sbcglobal.net
 [172.11.194.172])
 by mx1.freebsd.org (Postfix) with ESMTP id 045E21F2F
 for <freebsd-stable@freebsd.org>; Wed, 24 Aug 2016 05:41:11 +0000 (UTC)
 (envelope-from andreas@naund.org)
Received: (from andreas@localhost)
 by naund.org (8.11.6/8.11.6-20030329ao) id u7O5eUB10639;
 Tue, 23 Aug 2016 22:40:30 -0700
Date: Tue, 23 Aug 2016 22:40:30 -0700
From: Andreas Ott <andreas@naund.org>
To: Kevin Oberman <rkoberman@gmail.com>
Cc: Randy Bush <randy@psg.com>, FreeBSD Stable <freebsd-stable@freebsd.org>
Subject: Re: leapsecond file
Message-ID: <20160823224030.A9828@naund.org>
References: <m2wpjs102b.wl%randy@psg.com>
 <8092297e-7a0a-12c4-e115-4ed81d28f123@protected-networks.net>
 <m2a8gom1no.wl%randy@psg.com>
 <CAN6yY1vKqs70SjcN57b19LmAnJcHkV3KEPTR+=HZhjqc6A4rbg@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2.5.1i
In-Reply-To: <CAN6yY1vKqs70SjcN57b19LmAnJcHkV3KEPTR+=HZhjqc6A4rbg@mail.gmail.com>;
 from rkoberman@gmail.com on Sun, Aug 07, 2016 at 09:44:55PM -0700
X-BeenThere: freebsd-stable@freebsd.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: Production branch of FreeBSD source code <freebsd-stable.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-stable>, 
 <mailto:freebsd-stable-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-stable/>
List-Post: <mailto:freebsd-stable@freebsd.org>
List-Help: <mailto:freebsd-stable-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-stable>,
 <mailto:freebsd-stable-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 24 Aug 2016 05:41:12 -0000

On Sun, Aug 07, 2016 at 09:44:55PM -0700, Kevin Oberman wrote:
> On 11.0-BETA4 I have:
> > grep expires /var/db/ntpd.leap-seconds.list
> #    File expires on:  1 Jun 2017
> 
> But I see what you do on 10.3-RELEASE.  Looks like the update has not made
> it into 10 (an I would guess 9).

The flaw is in the internal versioning of files, it does fetch the newer
file from IETF and puts it into /var/run/ntpd.leap-seconds.list, but
although the expiry is newer, the FreeBSD onboard source version claims
to be newer in the 'last update date in NTP timestamp format' line ...

FreeBSD 10.3-RELEASE-p7 onboard source is in /etc/ntp/leap-seconds,
which gets copied to /var/db/ntpd.leap-seconds.list. The fetch
IETF file downloads to /var/run/ntpd.leap-seconds.list .


[root@mon ~]# egrep -e Update\|expires\|^'#\$' /etc/ntp/leap-seconds
#       Last Update of leap second values:  31 Dec 2015
#$       3660508800
#       Updated through IERS Bulletin C 50
#       File expires on:  1 Jun 2016
[root@mon ~]# egrep -e Update\|expires\|^'#\$' /var/db/ntpd.leap-seconds.list
#       Last Update of leap second values:  31 Dec 2015
#$       3660508800
#       Updated through IERS Bulletin C 50
#       File expires on:  1 Jun 2016
[root@mon ~]# egrep -e Update\|expires\|^'#\$' /var/run/ntpd.leap-seconds.list
#       Last Update of leap second values:   5 January 2015
#$       3629404800
#       Updated through IERS Bulletin C51
#       File expires on:  28 December 2016
[root@mon ~]#

with the end result that the file from /var/run/ never gets moved to /var/db/ .
The 480.leapfile-ntpd used by periodic calls the same rc file fetch and
comparison.

-andreas
-- 
Andreas Ott   K6OTT   +1.408.431.8727   andreas@naund.org