From owner-cvs-all Mon Jan 18 02:56:50 1999 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id CAA25292 for cvs-all-outgoing; Mon, 18 Jan 1999 02:56:50 -0800 (PST) (envelope-from owner-cvs-all@FreeBSD.ORG) Received: from axl.noc.iafrica.com (axl.noc.iafrica.com [196.31.1.175]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id CAA25279; Mon, 18 Jan 1999 02:56:39 -0800 (PST) (envelope-from sheldonh@axl.noc.iafrica.com) Received: from sheldonh (helo=axl.noc.iafrica.com) by axl.noc.iafrica.com with local-esmtp (Exim 2.10 #1) id 102CM3-0001GW-00; Mon, 18 Jan 1999 12:56:23 +0200 From: Sheldon Hearn To: Joseph Koshy cc: cvs-all@FreeBSD.ORG Subject: Re: cvs commit: ports/audio/mpg123/patches patch-aa In-reply-to: Your message of "Thu, 14 Jan 1999 21:34:04 PST." <199901150534.VAA17000@freefall.freebsd.org> Date: Mon, 18 Jan 1999 12:56:23 +0200 Message-ID: <4867.916656983@axl.noc.iafrica.com> Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk On Thu, 14 Jan 1999 21:34:04 PST, Joseph Koshy wrote: > jkoshy 1999/01/14 21:34:03 PST > > Modified files: > audio/mpg123/patches patch-aa > Log: > Honor CFLAGS. > > PR: ports/9488 > Submitted by: Sheldon Hearn > Reviewed by: jkoshy Hi Joseph, You don't seem to have applied my patch as submitted. That's not usually a problem ;), except that what you've applied produces different results from what I'd intended. The patch-aa file now sets up the following: CFLAGS+='$(CFLAGS) -Wall -O2 [...]' This means that stronger otpimization than I may want will be imposed on me. If you insist on keeping -O2 in place as a default, may I suggest you do it as follows: CFLAGS+='-Wall -O2 [...] $(CFLAGS)' This means that my '-O' will override the default -O2. Ciao, Sheldon. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message