From owner-svn-ports-all@freebsd.org Thu Jan 5 16:36:35 2017 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E8DD9CA0D1C; Thu, 5 Jan 2017 16:36:35 +0000 (UTC) (envelope-from freebsd.contact@marino.st) Received: from shepard.synsport.com (mail.synsport.com [208.69.230.148]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id C61901AC0; Thu, 5 Jan 2017 16:36:34 +0000 (UTC) (envelope-from freebsd.contact@marino.st) Received: from [127.0.0.1] (ip72-204-83-236.fv.ks.cox.net [72.204.83.236]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by shepard.synsport.com (Postfix) with ESMTP id E81E543D6F; Thu, 5 Jan 2017 10:35:10 -0600 (CST) Subject: Re: svn commit: r430643 - in head/comms/wsjtx: . files To: Diane Bruce , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org References: <201701051620.v05GKLks070469@repo.freebsd.org> Reply-To: marino@freebsd.org From: John Marino Message-ID: <8c56c1c0-5388-a74f-62df-af52146838e1@marino.st> Date: Thu, 5 Jan 2017 10:36:32 -0600 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: <201701051620.v05GKLks070469@repo.freebsd.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Antivirus: avast! (VPS 170105-0, 01/05/2017), Outbound message X-Antivirus-Status: Clean X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Jan 2017 16:36:36 -0000 On 1/5/2017 10:20, Diane Bruce wrote: > Author: db > Date: Thu Jan 5 16:20:21 2017 > New Revision: 430643 > URL: https://svnweb.freebsd.org/changeset/ports/430643 > > Log: > Fix svn properties. Bug in psvn! > Mark as broken on i386 > Note typo with include_directories had no effect on build but fixed anyway > > Modified: > head/comms/wsjtx/Makefile > head/comms/wsjtx/files/patch-CMakeLists.txt (contents, props changed) > head/comms/wsjtx/files/patch-Configuration.cpp > head/comms/wsjtx/files/patch-Radio.cpp (contents, props changed) > head/comms/wsjtx/files/patch-WFPalette.hpp (contents, props changed) > head/comms/wsjtx/files/patch-lib_wsprd_Makefile > head/comms/wsjtx/files/patch-manpages_CMakeLists.txt (contents, props changed) > > Modified: head/comms/wsjtx/Makefile > ============================================================================== > --- head/comms/wsjtx/Makefile Thu Jan 5 15:32:31 2017 (r430642) > +++ head/comms/wsjtx/Makefile Thu Jan 5 16:20:21 2017 (r430643) > @@ -37,4 +37,7 @@ do-extract: > ${TAR} xf ${DISTDIR}/${PORTNAME}-${PORTVERSION}${EXTRACT_SUFX} -C${WRKDIR} > ${TAR} xf ${WRKDIR}/${PORTNAME}-${PORTVERSION}/src/wsjtx.tgz -C${WRKDIR} > > +BROKEN_i386= does not build on i386 due to openmp > + > .include > + > Personally, I don't think this was necessary. devel/openmp has this line: ONLY_FOR_ARCHS= amd64 # i386 wsjtx would have been "skipped" due to openmp. Now if openmp suddenly supports i386, wsjtx is marked broken in error. I would have just left it. I think Jan's point was that you shouldn't put an unconditional dependency on openmp (make it optional), not that you should mark the port BROKEN on i386. You may have misunderstood him to begin with. John --- This email has been checked for viruses by Avast antivirus software. https://www.avast.com/antivirus