Date: Wed, 26 Aug 2020 18:09:19 +0100 From: Jessica Clarke <jrtc27@freebsd.org> To: Mateusz Guzik <mjguzik@gmail.com> Cc: Jung-uk Kim <jkim@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r364822 - in head/crypto/openssl/crypto: aes/asm bn/asm chacha/asm ec/asm modes/asm poly1305/asm sha/asm Message-ID: <1005AA00-136E-4C56-807B-391CEC2A0051@freebsd.org> In-Reply-To: <CAGudoHGfUpzbmjmd1Q=pG7LyOM3uCKEhq%2BiF6-X_p_SLKbyfVA@mail.gmail.com> References: <202008261655.07QGtSZx096979@repo.freebsd.org> <CAGudoHGfUpzbmjmd1Q=pG7LyOM3uCKEhq%2BiF6-X_p_SLKbyfVA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 26 Aug 2020, at 18:04, Mateusz Guzik <mjguzik@gmail.com> wrote: > > On 8/26/20, Jung-uk Kim <jkim@freebsd.org> wrote: >> Author: jkim >> Date: Wed Aug 26 16:55:28 2020 >> New Revision: 364822 >> URL: https://svnweb.freebsd.org/changeset/base/364822 >> >> Log: >> Fix Clang version detection. >> >> We prepend "FreeBSD" to Clang version string. This broke compiler test >> for >> AVX instruction support. >> > > What about other software checking in similar fashion? imo the right > fix is to stop mucking with the way clang reports itself Apple's LLVM also does the same thing. Whilst it may be better to leave the string alone, it is sometimes useful information and, given the existence of Apple's LLVM, well-behaved software should already be dealing with this properly; based on this commit, upstream OpenSSL seems like it suffers the same bug on macOS. Jess
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1005AA00-136E-4C56-807B-391CEC2A0051>