Date: Thu, 06 Jul 2023 10:34:57 +0200 From: Raphael Kubo da Costa <rakuco@FreeBSD.org> To: "Hurling, Rainer" <rhurlin@FreeBSD.org>, eduardo@FreeBSD.org Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: b56d0bc41af7 - main - devel/libcutl: Explain why USE_CXXSTD=c++11 is used Message-ID: <e56d377d0985b86be2291b64bb3c686742283dde.camel@FreeBSD.org> In-Reply-To: <ebcdf01a-2b73-39c3-b6e4-25659e53b1ca@gwdg.de> References: <202307050850.3658oPOA049562@gitrepo.freebsd.org> <CAFDf7UJRc4bd3XVq%2Bb7Za2cLN7h_hkN1mpPTGQiSajV1p9A=0g@mail.gmail.com> <ebcdf01a-2b73-39c3-b6e4-25659e53b1ca@gwdg.de>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 2023-07-05 at 13:39 +0200, Rainer Hurling wrote: > Hi Raphael, >=20 > This also helps me for games/eboard. I had been looking around for > some=20 > time and had not found a solution yet. I will also use parts of your=20 > explanation :) >=20 > Many thanks and best wishes, > Rainer >=20 >=20 > Am 05.07.23 um 11:13 schrieb Nuno Teixeira: > > Hello Raphael, > >=20 > > Really nice and explaining comment on std c++11 fixes. I will use > > same=20 > > comment on ports needed it to work in clang 16, e.g., net-p2p/amule > > that=20 > > needs it. > >=20 > > Just a question, should a PORTREVISION bump reccomended when we set > > USE_CXXSTD=3Dc++11? Hi both, Glad to be of help! Overall, this looks like a variation of what we had in the past especially when clang switched to C++11 by default and a lot of ports broke. Specifically in these 2 cases in case it helps: * games/eboard seems to be failing because it defines an enum called `variant` while also doing `using namespace std`, which breaks because C++17 has std::variant. * net-p2p/amule uses the `register` keyword in a bunch of places (including some autogenerated flex/bison ones that are part of the tree), and it has been removed/deprecated in C++17. As for a PORTREVISION bump: it _could_ be the case that the generated files differ now, as in the past the default standard was gnu++14 rather than c++11. For leaf ports like these two I don't think the difference really matters, but I've been semi-abstent for so long that portmgr@ or someone more active may have a better guideline.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?e56d377d0985b86be2291b64bb3c686742283dde.camel>