From owner-freebsd-arch@FreeBSD.ORG Wed May 20 15:24:37 2009 Return-Path: Delivered-To: arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 298891065670 for ; Wed, 20 May 2009 15:24:37 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id F046A8FC1A for ; Wed, 20 May 2009 15:24:36 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net [66.111.2.69]) by cyrus.watson.org (Postfix) with ESMTPSA id A6BC646B23; Wed, 20 May 2009 11:24:36 -0400 (EDT) Received: from jhbbsd.hudson-trading.com (unknown [209.249.190.8]) by bigwig.baldwin.cx (Postfix) with ESMTPA id 8B1B78A028; Wed, 20 May 2009 11:24:35 -0400 (EDT) From: John Baldwin To: "M. Warner Losh" Date: Wed, 20 May 2009 11:24:24 -0400 User-Agent: KMail/1.9.7 References: <200905121020.18497.jhb@freebsd.org> <20090520.085924.-1935226744.imp@bsdimp.com> In-Reply-To: <20090520.085924.-1935226744.imp@bsdimp.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200905201124.24747.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.0.1 (bigwig.baldwin.cx); Wed, 20 May 2009 11:24:35 -0400 (EDT) X-Virus-Scanned: clamav-milter 0.95 at bigwig.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-2.5 required=4.2 tests=AWL,BAYES_00,RDNS_NONE autolearn=no version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on bigwig.baldwin.cx Cc: arch@freebsd.org Subject: Re: Remove d_thread_t for 8.0 X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 May 2009 15:24:37 -0000 On Wednesday 20 May 2009 10:59:24 am M. Warner Losh wrote: > In message: <200905121020.18497.jhb@freebsd.org> > John Baldwin writes: > : In the same vein as purging BURN_BRIDGES stuff, is there any objection to > : removing d_thread_t from 8.0? It is intended as a compat shim to reduce > : diffs with 4.x. However, at this point drivers are not actively being merged > : back to 4.x, so I think it is no longer necessary. > > It was also intended to allow easier sharing for folks that were using > FreeBSD 4.x, 5.x, etc. I know that at least one user still has some > 4.x deployments, but I suspect that they are otherwise off 4.x so it > might not be a problem for them. It would be yet another thing to > change when going from 7.x to 8.x for them... > > We certainly should remove it from the drivers in the tree for 8.0. > Right now it is used in about a two dozen places. Even in a shared driver I believe the function prototypes for devsw routines would already have to be #ifdef'd due to the 'dev_t' -> 'struct cdev *' change which does have a similar foo_t typedef to ease the transition. Given that, any code compiled for 7.0+ is already using a function prototype that is not compatible with 4.x and there isn't a need for it to use d_thread_t. They can just use 'struct thread *' always when using 'struct cdev *'. -- John Baldwin