From owner-freebsd-current@FreeBSD.ORG Tue Oct 12 20:11:30 2010 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8C6141065695 for ; Tue, 12 Oct 2010 20:11:30 +0000 (UTC) (envelope-from yanegomi@gmail.com) Received: from mail-gy0-f182.google.com (mail-gy0-f182.google.com [209.85.160.182]) by mx1.freebsd.org (Postfix) with ESMTP id 3EB5B8FC1E for ; Tue, 12 Oct 2010 20:11:29 +0000 (UTC) Received: by gyf3 with SMTP id 3so1332140gyf.13 for ; Tue, 12 Oct 2010 13:11:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:sender:received :in-reply-to:references:date:x-google-sender-auth:message-id:subject :from:to:cc:content-type:content-transfer-encoding; bh=M129JlZwmEhZquujEU3d0md3PXuoa+GO8bJSRlPOsEc=; b=Uwbm6PCuJdJqV+msR1mJ/GEnLo+/lDdlasRP9Z3U4OCgwhrt91AvSSacHxSiGUcC14 ym/1FxKvWCca0SktmsVSGC42RCCm/mGfR1+XK0z4e5FO+Q59SZtASF2YyGvxIvvZ+X4H 4hbdsGJYGfoReYvlhlg0AonSEtBvoUx43s/i0= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=EsWQz2XaYXhlRHYQk/RVTo3LxL0uNrpdX7juF9WiqcsoPpfs+6oXTcWu4VClLVRTDS TCCYuCzyY+lHYlmoysZaCR7Tg7mt5xwvYSfmo8MSHL4XTWshimLbpbK7YPx7feFDzN9A Al4V0VkZ/rpAKaDEeOLb00LfyqAvbLyo1qapc= MIME-Version: 1.0 Received: by 10.90.73.9 with SMTP id v9mr3847248aga.89.1286914289375; Tue, 12 Oct 2010 13:11:29 -0700 (PDT) Sender: yanegomi@gmail.com Received: by 10.90.109.16 with HTTP; Tue, 12 Oct 2010 13:11:29 -0700 (PDT) In-Reply-To: <20101012192340.GG10094@michelle.cdnetworks.com> References: <20101011225331.GA2829@troutmask.apl.washington.edu> <20101011231604.GI4607@michelle.cdnetworks.com> <20101012000216.GA1554@troutmask.apl.washington.edu> <20101012000927.GK4607@michelle.cdnetworks.com> <20101012001510.GA6789@troutmask.apl.washington.edu> <20101012002621.GA1554@troutmask.apl.washington.edu> <20101012003329.GL4607@michelle.cdnetworks.com> <20101012152440.GA1615@troutmask.apl.washington.edu> <20101012192340.GG10094@michelle.cdnetworks.com> Date: Tue, 12 Oct 2010 13:11:29 -0700 X-Google-Sender-Auth: tRoMiwtmkxPYiactrq20qfNlYFE Message-ID: From: Garrett Cooper To: pyunyh@gmail.com Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: freebsd-current@freebsd.org, Steve Kargl Subject: Re: recent bge(4) changes causing problems X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Oct 2010 20:11:30 -0000 On Tue, Oct 12, 2010 at 12:23 PM, Pyun YongHyeon wrote: > On Tue, Oct 12, 2010 at 08:24:40AM -0700, Steve Kargl wrote: >> On Mon, Oct 11, 2010 at 05:33:29PM -0700, Pyun YongHyeon wrote: >> > >> > Thanks for the info. I still suspect r213495 might break BCM5704. >> > Due to lack of BCM5704 I still couldn't test it except guessing. >> > How about attached one? >> >> > Index: sys/dev/bge/if_bge.c >> > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >> > --- sys/dev/bge/if_bge.c =A0 =A0(revision 213711) >> > +++ sys/dev/bge/if_bge.c =A0 =A0(working copy) >> > @@ -1736,7 +1736,8 @@ >> > =A0 =A0 =A0 =A0 =A0 =A0 RCB_WRITE_4(sc, vrcb, bge_hostaddr.bge_addr_hi= , 0); >> > =A0 =A0 =A0 =A0 =A0 =A0 RCB_WRITE_4(sc, vrcb, bge_hostaddr.bge_addr_lo= , 0); >> > =A0 =A0 =A0 =A0 =A0 =A0 RCB_WRITE_4(sc, vrcb, bge_maxlen_flags, >> > - =A0 =A0 =A0 =A0 =A0 =A0 =A0 BGE_RCB_FLAG_RING_DISABLED); >> > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 BGE_RCB_MAXLEN_FLAGS(sc->bge_return_ring= _cnt, >> > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 BGE_RCB_FLAG_RING_DISABLED)); >> > =A0 =A0 =A0 =A0 =A0 =A0 RCB_WRITE_4(sc, vrcb, bge_nicaddr, 0); >> > =A0 =A0 =A0 =A0 =A0 =A0 bge_writembx(sc, BGE_MBX_RX_CONS0_LO + >> > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 (i * (sizeof(uint64_t))), 0); >> >> Unfortunately, this patch does not fix the issue. >> >> If I revert r213495 via 'svn merge -r213495:213494 .' >> in the sys/dev/bge directory, I can build a working >> kernel. =A0So, I can confirm that r213495 is the source >> of the problem with a BCM5704 based NIC. >> > > Fix committed to HEAD(r213742). Could this be a firmware bug? A similar issue has occurred in the past with bce(4) where you have to upgrade the firmware and the driver in tandem in order for things to function properly, so maybe if the firmware was upgraded to the latest version (unfortunately only Linux methods exist I think), this issue would go away? Thanks, -Garrett